Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] pane can be overscrolled #171

Closed
tsungweihsu opened this issue Jan 12, 2022 · 6 comments
Closed

[BUG] pane can be overscrolled #171

tsungweihsu opened this issue Jan 12, 2022 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@tsungweihsu
Copy link

tsungweihsu commented Jan 12, 2022

Describe the bug
When top is defined, the pane can be overscrolled away from the view port. Please find the video attached.

To Reproduce
Steps to reproduce the behavior:

  1. Create a pane with top defined
  2. Drag the pane to the top and overscroll it
  3. The pane can be scrolled away from the view port

Expected behavior
The pane should be fixed when overscrolled.

Screenshots

overscroll.mp4

Smartphone (please complete the following information):

  • Device: Pixel 4 Emulator, Pixel 4a
  • Version 1.2.81 & 1.2.8

Additional context
This only happens with Android not iOS.

@roman-rr roman-rr self-assigned this Jan 12, 2022
@roman-rr
Copy link
Collaborator

@tsungweihsu big thanks for report. Probably a case regards to 1.2.8. i will check it

@roman-rr roman-rr added the bug Something isn't working label Jan 12, 2022
@szymek
Copy link

szymek commented Jan 12, 2022

+1

1 similar comment
@bujaczes
Copy link

+1

@roman-rr
Copy link
Collaborator

roman-rr commented Jan 13, 2022

@tsungweihsu @bujaczes @szymek please share for me exact settings configuration CupertinoSettings used for CupertinoPane instance.

@tsungweihsu
Copy link
Author

settings: CupertinoSettings = {
    parentElement: 'body',
    buttonClose: false,
    breaks: {
      top: {enabled: true, height: window.innerHeight },
      middle: {enabled: true, height: window.innerHeight * 0.5},
      bottom: {enabled: true, height: 100}
    }
  };

I did a deeper testing to see what really triggers this behavior and found that when top is defined to be the same height as the view port, the pane can be swiped away.

@roman-rr
Copy link
Collaborator

Just pushed 1.2.82 which should fix the bug!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants