Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Pane opens itself after unlocking mobile device #159

Closed
tsungweihsu opened this issue Jul 28, 2021 · 6 comments
Closed

[BUG] Pane opens itself after unlocking mobile device #159

tsungweihsu opened this issue Jul 28, 2021 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@tsungweihsu
Copy link

Hello Roman,

we found an interesting behavior in Android devices, please have a look 🔎

Describe the bug
When the pane is hidden by the method hide(), it opens itself after the device is being unlocked.

To Reproduce
Steps to reproduce the behavior:

  1. Create a pane
  2. Hide the pane using hide()
  3. Lock the device while the app is in foreground
  4. Unlock the device
  5. The app reappears and the pane jumps up

Expected behavior
The pane should stay hidden 🙈

Screenshots

Smartphone:

  • Framework: Ionic 5
  • Device: Pixel 4 (emulator), Pixel 4a (real device)
  • Version 30

Additional context
This issue is not present in iOS 👌

@roman-rr roman-rr self-assigned this Jul 28, 2021
@roman-rr roman-rr added the bug Something isn't working label Jul 28, 2021
@roman-rr
Copy link
Collaborator

@tsungweihsu Please provide a video from Device: Pixel 4 (emulator)

@tsungweihsu
Copy link
Author

@roman-rr The GIF attached to the post above is already the screen from the emulator (Pixel 4), you can see the mouse moving within. But I attach a new video to this one. The app contains nothing but the pane (1.2.7).

autoprompt.mp4

@roman-rr
Copy link
Collaborator

roman-rr commented Aug 1, 2021

@tsungweihsu
What software do you use for emulator ? This is not look like default android studio avd.
I've tested on device Samsung A51, bug doesn't appears.

I'm pretty sure that this is somethings with unlock transition.
After drag to the top gesture, applications viewport do transition or height changes.
From bottom to the top animation on your videos.
On Samsung A51 has other unlock animation for apps. Or maybe you change it somewhere ?

@tsungweihsu
Copy link
Author

@roman-rr
I am using the default emulator from Android Studio. I've tested further with Pixel 3a (emulator) in different scenarios, please find them in the following videos:

  1. No unlock passwords, swipe up to unlock.
no-password.mp4
  1. Unlock with fingerprint but wake up the phone first
with-fingerprint.mp4
  1. Unlock with fingerprint directly while the screen is off (the most common scenario in real life use)
with-fingerprint-direct.mp4
  1. Unlock with manually typing password (the pane does not jump up)
type-password.mp4

Additional observed behavior:

  • The pane will no longer show up by itself when it is destroyed by destroy().
  • The temporary solution is to destroy the pane with animation set true to mimic hide(), and present() it later when in use.

@roman-rr
Copy link
Collaborator

roman-rr commented Aug 3, 2021

@tsungweihsu Thank you for such good details provided. Should be fixed on master branch.
The reason of issue is because android trigger window.resize for unlock device events.

@roman-rr roman-rr closed this as completed Aug 3, 2021
@Tvde1
Copy link

Tvde1 commented Sep 21, 2021

👍🏻 also fixes the pane opening whenever the browser window is resized :) great work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants