Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] maxHeight settings for use with fitHeight setting #122

Closed
sjregan opened this issue Jan 19, 2021 · 3 comments
Closed

[FEAT] maxHeight settings for use with fitHeight setting #122

sjregan opened this issue Jan 19, 2021 · 3 comments

Comments

@sjregan
Copy link

sjregan commented Jan 19, 2021

What are you trying to add to Cupertino-Pane?

Setting for maximum pane height when fitHeight setting is true. eg maxHeight - an integer representing maximum height in pixels.

Describe your feature request detailed

If fitHeight is true and the pane contains a long list, the height of the displayed pane may end up the height of the window. If maxHeight was set, and the calculated pane height is greater than maxHeight, set the pane height to maxHeight.

Is there an alternative at the latest version?

[ ] Yes (descripe the alternative)
[ X] No

Is this related to an issue?

[X] Yes (Give a link to the issue)
[ ] No

#113

@roman-rr
Copy link
Collaborator

@sjregan Please check in v.1.2.2 option fitScreenHeight: true.

@sjregan
Copy link
Author

sjregan commented Jan 19, 2021

@roman-rr I have seen the option fitScreenHeight: true thank you, what I would like to be able to do is set the maximum height of the pane to the height of the screen minus X pixels.

The reason for this is so the page title behind the pane can still be seen to give the pane context.

@roman-rr
Copy link
Collaborator

@sjregan Please check 1.2.3

let settings = {
  fitHeight: true, 
  maxFitHeight: 400
};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants