Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FSD: Widget Support #567

Open
Quiddlee opened this issue Sep 27, 2024 · 0 comments
Open

FSD: Widget Support #567

Quiddlee opened this issue Sep 27, 2024 · 0 comments
Assignees
@KristiBo
Labels
high priority refactor
Milestone
🛸 Migration to Fe...

Comments

@Quiddlee
Copy link
Collaborator

📝 Describe the refactoring task

Part of the issue #347

📍 Code location

src/widgets/support

✅ Definition of Done (DoD):

support.module.scss

  1. Refactor scss as following
  • remove all parent selector & .card-content -> .card-content.
  • change all possible values to variables if such exists.
  • and everything in your opinion that needs to be refactored
  • replace all element selectors by tag with class selector img -> .image

support.tsx

  1. replace div's with HTML5 tags
  2. rename image to something more meaningfull.
  3. add descriptive alt attribute

support.test.tsx

  1. move test file to ui folder
  2. replace support link with constant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KristiBo KristiBo

Labels
high priority refactor
Projects
RS Site
Status: In Progress
Milestone
🛸 Migration to Feature Sliced Design ...
Development

No branches or pull requests
2 participants
@KristiBo @Quiddlee