Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSD: Widget School-menu #563

Open
Quiddlee opened this issue Sep 27, 2024 · 0 comments
Open

FSD: Widget School-menu #563

Quiddlee opened this issue Sep 27, 2024 · 0 comments

Comments

@Quiddlee
Copy link
Collaborator

Quiddlee commented Sep 27, 2024

πŸ“ Describe the refactoring task

Part of the issue #347

πŸ“ Code location

src/widgets/school-menu

βœ… Definition of Done (DoD):

school-menu.module.scss

  1. Refactor school-menu.tsx's scss as following
  • remove all parent selector & .card-content -> .card-content.
  • change all possible values to variables if such exists.
  • and everything in your opinion that needs to be refactored
  • replace all element selectors by tag with class selector img -> .image

school-menu.tsx

  1. replace div's with HTML5 tags
  2. replace interface with type
  3. move getMenuItem to school-menu/helpers
  4. replace template string in className with classnames
  5. move school-menu component and all related pieces to school-menu/ui/school-menu

school-item.tsx

  1. replace interface with type
  2. replace ternary operator in className with classnames
  3. place all the object property checks in constants
  4. extract styles from school-item's scss and create separate scss file for school-item component

school-list.tsx

  1. replace all the interfaces with types
  2. replace complex className constant with classnames
  3. extract styles from school-item's scss and create separate scss file for school-list component

school-list.test.tsx

  1. replace all the links with constants

constants.ts

  1. move constants to constants.ts
  2. move all the anchor links to the shared ANCHORS constant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

1 participant