Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSD: Widget Principles #560

Open
Quiddlee opened this issue Sep 26, 2024 · 0 comments
Open

FSD: Widget Principles #560

Quiddlee opened this issue Sep 26, 2024 · 0 comments

Comments

@Quiddlee
Copy link
Collaborator

πŸ“ Describe the refactoring task

Part of the issue #347

πŸ“ Code location

src/widgets/principles

βœ… Definition of Done (DoD):

principles.module.scss & principles-card.module.scss

  1. Refactor principles.tsx's scss as following
  • remove all parent selector & .card-content -> .card-content.
  • change all possible values to variables if such exists.
  • and everything in your opinion that needs to be refactored
  • replace all element selectors by tag with class selector img -> .image

principles.tsx

  1. create principles folder inside the ui folder
  2. move all the related pieces to the principles folder
  3. replace div's with HTML5 tags

principles-card.tsx

  1. replace interface with type
  2. extract type and place it inside types.ts file near the constants.ts
  3. rename the type to PrincipleCard
  4. replace div's with HTML5 tags

constants.ts

  1. replace all the icon wrappers with Image component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

1 participant