Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSD: Widget Places #559

Open
Quiddlee opened this issue Sep 26, 2024 · 0 comments
Open

FSD: Widget Places #559

Quiddlee opened this issue Sep 26, 2024 · 0 comments

Comments

@Quiddlee
Copy link
Collaborator

πŸ“ Describe the refactoring task

Part of the issue #347

πŸ“ Code location

src/widgets/places

βœ… Definition of Done (DoD):

places.module.scss

  1. Refactor places.tsx's scss as following
  • remove all parent selector & .card-content -> .card-content.
  • change all possible values to variables if such exists.
  • and everything in your opinion that needs to be refactored
  • replace all element selectors by tag with class selector img -> .image

places.tsx

  1. replace div's with HTML5 tags
  2. move places const to constants.ts
  3. remove string[] type
  4. get rid of Marquee library

places.test.tsx

  1. move test file to ui folder
  2. remove redundant places constant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

1 participant