Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidekiq report threshold #318

Closed
pacoguzman opened this issue Oct 14, 2015 · 5 comments
Closed

Sidekiq report threshold #318

pacoguzman opened this issue Oct 14, 2015 · 5 comments

Comments

@pacoguzman
Copy link
Contributor

Rollbar extensions includes some configuration parameters to report error since a specific job attempt when using delayed job, but not when using Sidekiq.

Would you accept a PR that solve that?
@jondeandres
Copy link
Contributor

@pacoguzman sure, feel free to open a new PR and we can then discuss over the code.

Thanks!

@pacoguzman pacoguzman mentioned this issue Oct 14, 2015
Merged
@pacoguzman
Copy link
Contributor Author

@jondeandres I just created one #319

@jondeandres
Copy link
Contributor

awesome 😄

@aselder
Copy link
Contributor

aselder commented Nov 23, 2015

There is a big issue with this PR: #345

@jondeandres
Copy link
Contributor

This can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pacoguzman @aselder @jondeandres