Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary type attribute from Rollbar.js output #1020

Closed
AlecRust opened this issue Dec 8, 2020 · 0 comments · Fixed by #1091
Closed

Remove unnecessary type attribute from Rollbar.js output #1020

AlecRust opened this issue Dec 8, 2020 · 0 comments · Fixed by #1091
Assignees
@waltjones

Comments

@AlecRust
Copy link

AlecRust commented Dec 8, 2020

I notice your Browser JS docs suggest putting the Rollbar.js config in <script> which is suitable for HTML5, but when I enable Rollbar.js within this gem it outputs the unnecessary type attribute (<script type="text/javascript">) at the top of my <head>.

Rails doesn't include this type="text/javascript" attribute any more, can you remove it from this gem's output too?
@waltjones waltjones self-assigned this Mar 2, 2021
@waltjones waltjones removed their assignment Mar 17, 2021
@waltjones waltjones self-assigned this Mar 31, 2022
@waltjones waltjones mentioned this issue Mar 31, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@waltjones waltjones

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove type attribute from script tag rollbar/rollbar-gem
2 participants
@waltjones @AlecRust