Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce file looping during scope validation #1108

Closed
TwitchBronBron opened this issue Mar 11, 2024 · 1 comment
Closed

Reduce file looping during scope validation #1108

TwitchBronBron opened this issue Mar 11, 2024 · 1 comment
Labels
enhancement New feature or request
Milestone
v1.0.0

Comments

@TwitchBronBron
Copy link
Member

#1105 moved all scope validation into BscPlugin. However, it was then noticed that there are two separate loops iterating over files in that PR (see this comment).

We should optimize the validators to do a single loop instead of multiple.
@TwitchBronBron TwitchBronBron added the enhancement New feature or request label Mar 11, 2024
@TwitchBronBron TwitchBronBron added this to the v1.1.0 milestone Mar 11, 2024
@markwpearce
Copy link
Collaborator

potentially not an issue anymore after #1123

@TwitchBronBron TwitchBronBron modified the milestones: v1.1.0, v1.0.0 Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
2 participants
@markwpearce @TwitchBronBron