Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate transpiling invalid in callfuncs #1018

Closed
TwitchBronBron opened this issue Jan 16, 2024 · 0 comments
Closed

Eliminate transpiling invalid in callfuncs #1018

TwitchBronBron opened this issue Jan 16, 2024 · 0 comments
Milestone

Comments

@TwitchBronBron
Copy link
Member

Historically, callfuncs would fail if you didn't pass at least 1 argument (even if that argument was invalid). BrighterScript supported this by making the callfunc operator always inject an invalid as the first argument if you specified no arguments.

However, in recent years that problem seems to have been fixed in the Roku OS, so this feature is no longer necessary.

Actions:

  • by default, do NOT inject the invalid as the first argument to callfunc operator statements.
  • add a bsconfig option to re-enable this feature (for legacy purposes) since this can result in code not running properly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants