Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action uses non-standard configuration location #109

Closed
proffalken opened this issue Aug 4, 2022 · 3 comments · Fixed by #116
Closed

Action uses non-standard configuration location #109

proffalken opened this issue Aug 4, 2022 · 3 comments · Fixed by #116
Assignees
Labels
enhancement New feature or request

Comments

@proffalken
Copy link
Contributor

In order to ensure good developer experience, we want to allow developers to run the same commands on their workstations as is run by the CI.

Unfortunately this is not possible with spellcheck-github-actions, as it relies on .spellcheck.yaml whereas pyspellcheck relies on .pyspelling.yaml.

This means that we either cater to the github action and tell our developers to run pyspelling with the -c flag set, or we have to change the config for the action to explicitly include .pyspelling.yaml.

Given that the PySpelling default config location is .pyspelling.yaml it would be great if this file was also added to the list of default configuration files.

If people are open to this change, I'm more than happy to create the PR to fix it! :)

@jonasbn jonasbn self-assigned this Aug 4, 2022
@jonasbn
Copy link
Collaborator

jonasbn commented Aug 4, 2022

Hi @proffalken

Thanks for raising the issue, I will evaluate and get back to you.

@jonasbn jonasbn added the enhancement New feature or request label Aug 4, 2022
@jonasbn
Copy link
Collaborator

jonasbn commented Aug 4, 2022

As stated in the initial description the default configuration file for PySpelling is named: .pyspelling.yml.

REF: PySpelling documentation

@jonasbn
Copy link
Collaborator

jonasbn commented Aug 4, 2022

Hi @proffalken

A PR would be most welcome.

Please be aware, that we might need to take into consideration both variations of YAML suffixes.

  • *.yml
  • *.yaml

According to the documentation, *.yml is used, but in the code both are supported if I am not mistaken.

However since the parameter is feed to --config, we might as well accommodate for both, since they are both valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants