[Question] Why use scrollHeight in particular?

[Titozzz]

This lib gets children size with scrollHeight but it can cause issues if that child contains something with a dropdown that would not be displayed but would still count towards scrollHeight.
We found workarounds in our use cases but we were wondering why this choice?
There are some alternatives: https://medium.com/@jbbpatel94/difference-between-offsetheight-clientheight-and-scrollheight-cfea5c196937

🚀

[roginfarrer]

Quite frankly I struggle to grasp the difference between all of them. If I recall correctly I tried each of them in the library, and landed with scrollHeight since it seemed to work without any issues. I'm open to a PR to change it if we can document a good reason for the change.

[roginfarrer]

Ah, I think I remember. When debugging #14, I discovered that when padding is applies to the collapse element, scrollHeight is the only measurement that is accurate. In this example, I changed the measurement to clientHeight, and it ends the transition prematurely.

See screenshot:

[Titozzz]

I think offsetHeight might be what we want

[roginfarrer]

Closing this for now. Its stale, and I think scrollHeight leads to the most reliable behavior.