Make print and show consistent for WindowsPaths #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #88 +/- ##
==========================================
+ Coverage 87.96% 88.75% +0.78%
==========================================
Files 12 12
Lines 1039 1005 -34
==========================================
- Hits 914 892 -22
+ Misses 125 113 -12
Continue to review full report at Codecov.
|
|
Hm, do we really want this? I mean, the standard way of representing windows paths is with backslash... |
|
I’m not sure, but it does seem weird that show already does this. |
|
So my gut feeling is that we would want to always use backslash for Windows path everywhere, given that that is the "normal" way on Windows. But I also don't know whether that might have negative consequences somewhere else ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #87
@davidanthoff Would you mind reviewing this? I don't do a lot of work on Windows, so I'm not very confident that this won't break things.
NOTE: This seems to break compatibility with base Julia.