Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mktempdir should support cleanup=true by default #141

Open
ericphanson opened this issue Oct 15, 2021 · 1 comment · May be fixed by #150
Open

mktempdir should support cleanup=true by default #141

ericphanson opened this issue Oct 15, 2021 · 1 comment · May be fixed by #150
Labels
enhancement New feature or request

Comments

@ericphanson
Copy link
Contributor

ericphanson commented Oct 15, 2021 •
edited
Loading

to match Julia base on 1.3+. This would be something like adding atexit(() -> rm(dir; recursive=true)) inside mktempdir().
@rofinn rofinn added the enhancement New feature or request label Nov 16, 2021
@rofinn
Copy link
Owner

rofinn commented Nov 16, 2021

Hmm, I suppose we can provide that very basic fallback for now. I suspect it won't work properly for all filesystems. For example, the base code:

  1. Maintains a proper registry of temp paths to cleanup
  2. Handles locking and unlocking the registry for concurrent updates
  3. Handles chmod permissions

I don't think this is applicable for S3Path, but it'll likely require overloading a custom temp_cleanup method.

@rofinn rofinn linked a pull request Nov 17, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revise overloaded temp methods rofinn/FilePathsBase.jl
2 participants
@rofinn @ericphanson