Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing line comment to disable check #214

Closed
Aethylred opened this issue Aug 18, 2013 · 8 comments
Closed

Trailing line comment to disable check #214

Aethylred opened this issue Aug 18, 2013 · 8 comments
Labels
Milestone

Comments

@Aethylred
Copy link

I'm using a specific example here, but could it be possible to disable a check on a single line in a puppet file?

Sometimes we want to embed a variable in a single quoted string in a couple of places in the code usually because it needs to go into a file verbatim, but don't want to disable the check for the whole file.

I'm suggesting something of the form:

$thing => 'setting  = ${external_var}', #$ lint skip-single_quote_string_with_variables-check

Using the #$ to designate an 'active comment'

@ghoneycutt
Copy link
Contributor

+1 for a simple fix.

@jameskyle
Copy link

running into this one myself.

@vStone
Copy link
Contributor

vStone commented Aug 21, 2013

This might be easier to implement than #68 but this will also make lines that are already too long even longer.

@Aethylred
Copy link
Author

@vStone I agree, so perhaps a complete and abbreviated form is required. I'd still recommend a decorated comment marker e.g. #$ instead of just #

@spil-ruslan
Copy link

+1

@rodjek rodjek added the feature label Mar 4, 2014
@hashar
Copy link

hashar commented Apr 2, 2014

The python linting tool pep8 let one add a comment at the end of line with "noqa". Ie:

somepython = foo  # noqa

Commented on #247

@jantman
Copy link

jantman commented Jul 30, 2014

I know it's python-specific (AFAIK), but +1 for pep8's "# noqa"

@rodjek
Copy link
Owner

rodjek commented Aug 17, 2014

Implemented in #266

@rodjek rodjek closed this as completed Aug 17, 2014
@rodjek rodjek added this to the 1.0.0 milestone Aug 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants