Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect install directory is create if the organization name contains a dash #261

Closed
curator opened this issue Oct 9, 2014 · 1 comment
Closed

Incorrect install directory is create if the organization name contains a dash #261

curator opened this issue Oct 9, 2014 · 1 comment

Comments

@curator
Copy link

curator commented Oct 9, 2014

Due to a bit of naivete here (https://github.com/rodjek/librarian-puppet/blob/master/lib/librarian/puppet/util.rb#L56), modules with dashes in the org name (say... pwnies-ci/pwnies) will end up being installed into incorrect directory (ci-pwnies) names, which causes the module to not be found in puppet.
@carlossg
Copy link
Collaborator

I think organizations shouldn't have dashes, but sounds fare, we can assume that modules don't have dashes as stated in the Puppet docs

carlossg pushed a commit that referenced this issue Oct 10, 2014
Issue #261 Incorrect install directory is created if the organization…
4838707 
… name contains a dash

Assume organization can contain dashes, but not the module name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carlossg @curator