Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break puppet dependency for metadata reading #139

Open
ringods opened this issue Oct 24, 2013 · 1 comment
Open

Break puppet dependency for metadata reading #139

ringods opened this issue Oct 24, 2013 · 1 comment

Comments

@ringods
Copy link
Contributor

ringods commented Oct 24, 2013

Librarian-puppet only has a development dependency on puppet, but the code for processing Git sources in a Puppetfile still uses Puppet code directly to read the Puppet metadata file to figure out the module version and it's dependencies.

If the puppet gem isn't a dependency, then we need to get rid of the Puppet metadata reader in the Git code.

This change request is directly related to #134.

Should we duplicate the metadata reading code in here (Apache2 to MIT License?), or ask Puppetlabs to break it of in a separate gem? @joshcooper, can you give the Puppetlabs perspective on this?

@ringods
Copy link
Contributor Author

ringods commented Jan 9, 2014

I submitted an Improvement request in the new PuppetLabs JIRA to split out the Modulefile handling in a separate gem:

https://tickets.puppetlabs.com/browse/PUP-1188

With this functionality as a separate gem, it would solve the Puppet code dependency that is now still in place:

https://github.com/rodjek/librarian-puppet/blob/master/lib/librarian/puppet/source/git.rb#L74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant