Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cyclon exchange_view() should not return back to the source a partialView containing the source's ip #3

Closed
robzenn92 opened this issue Oct 23, 2017 · 1 comment
Labels

Comments

@robzenn92
Copy link
Owner

robzenn92 commented Oct 23, 2017

In cyclon/app.py the following piece of code is wrong.

source = message.get('source')
size = received_partial_view.size
to_avoid = None
if cyclon.partialView.contains_ip(source):
    to_avoid = cyclon.partialView.get_peer_by_ip(source)
to_send = cyclon.partialView.select_neighbors(to_avoid, size)

In fact, source is in the form http://<source_ip>:<port> while both cyclon.partialView.contains_ip and cyclon.partialView.get_peer_by_ip expect an IP. Hence, to_avoid value was alway None.

@robzenn92
Copy link
Owner Author

The code is not needed anymore cause cyclon returns a random subset of descriptors no matter if the source ip is included or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant