Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gulp 5 compat: stop using merge-stream #80

Open
dkseatgeek opened this issue Aug 12, 2024 · 2 comments
Open

gulp 5 compat: stop using merge-stream #80

dkseatgeek opened this issue Aug 12, 2024 · 2 comments

Comments

@dkseatgeek
Copy link

This package uses ternary-stream, which uses merge-stream, which isn't supported in gulp 5: gulpjs/gulp#2802

I worked around the issue by switching to a different gulp conditional package, but this package is the most popular by far out of the options I found so wanted to flag it in case someone wanted to update it.

@robrich
Copy link
Owner

robrich commented Aug 15, 2024

Good find! gulp is more-or-less no longer a thing now that Webpack and Vite are things. Which package should we use instead of ternary-stream?

@dkseatgeek
Copy link
Author

dkseatgeek commented Aug 18, 2024

So we actually ended up just removing all gulp conditional logic in the end (looking to move away from gulp ultimately), but the linked issue suggests ordered-read-streams as a streaming package that doesn't contain the problematic streaming option. Not familiar enough with streaming APIs to know if it would work for this package as a drop-in replacement though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants