You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Sure, I created a repo that shows each scenario. Had to point to a different version of gulp-fail since that was broken also.
Run through each task. When fail is invoked we don't expect the stream to end of course (since we exit early). But when we move through successfully, end should be called, and yet it is only called when a a boolean is passed. I've seen this a number of times, and clearly whoever created gulp-exit has also. If I have time, I'll track it down, and submit a PR, but currently I don't have the time.
When I use a function as condition, stream never ends. An example probably works best.
In this case, everything ends up in dist, and stream ends.
So in console you see:
In the function case everything still ends up in dist, but stream doesn't end.
In console you see:
Obviously this is an issue because we need the stream to end for other tasks to know it completed (it can't be a dependency task otherwise).
Am I doing something wrong? It seems like these cases should behave identically.
The text was updated successfully, but these errors were encountered: