Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to support php 7.1 #22

Open
Cuihongsen opened this issue Nov 3, 2017 · 5 comments
Open

How to support php 7.1 #22

Cuihongsen opened this issue Nov 3, 2017 · 5 comments
Labels

Comments

@Cuihongsen
Copy link

How to support php 7.1

@robregonm
Copy link
Owner

Theoretically, it is already supported. If you are experiencing issues, feel free to report here (if it is related to this library) or report to mpdf repo (in case it is related to mpdf directly)

@zoran-grujic
Copy link

No, PHP 7 is not actually supported. It is required to update mpdf first, but then yii2-pdf is not compatible with mpdf v7. To make it compatible one need to change class name from mPDF to Mpdf and Mpdf accepts single input parameter that is actually array of mPDF parameters. See post:

https://harrybailey.com/2018/08/yii-1-php-7-1-yii-pdf-and-mpdf/

I would like to update in a clean way yii2-pdf and mpdf v7. Is there an easy way to do it? Shall I fork yii2-pdf and make it work for mpdf v7?

@robregonm
Copy link
Owner

Feel free to submit a PR, or to become a contributor :-)

@zoran-grujic
Copy link

I am not big git master, but I think I managed to send two pull requests with changes that might do the job. And you can mark it as new version after merge...

@Julian-B90
Copy link
Contributor

@robregonm i have made a PR for this issue #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants