Change references from RGBDSensorWrapper to rgbdSensor_nws_yarp #3150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the release notes by adding a file in |
traversaro
temporarily deployed
to
code-analysis
GitHub Actions
Inactive
traversaro
had a problem deploying
to
code-analysis
GitHub Actions
Failure
traversaro
temporarily deployed
to
code-analysis
GitHub Actions
Inactive
I do not think that it would be useful to clutter the release note with the reference to such as small fix. |
Nicogene
approved these changes
Nov 25, 2024
randaz81
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
RGBDSensorWrapperdevice was deprecated in YARP 3.5 and removed in YARP 3.8 (see 4da405c) and it has been substituted byrgbdSensor_nws_yarp. Note that the corresponding network wrapper client (nwc) device that reads the rgbd data from a YARP port is calledRGBDSensorClient.However, there was still docs that was referring to
RGBDSensorWrapper, this PR fixes those occurrences.fyi @nicktrem @davidegorbani