From 8f121867859641754d1d14a1215cca8e8c1f7468 Mon Sep 17 00:00:00 2001 From: Marco Randazzo Date: Thu, 17 Oct 2024 12:14:39 +0200 Subject: [PATCH] removed topIsLow from FakeFrameGrabber --- .../fake/fakeFrameGrabber/FakeFrameGrabber.cpp | 15 --------------- .../FakeFrameGrabber_ParamsParser.cpp | 16 +--------------- .../FakeFrameGrabber_ParamsParser.h | 3 +-- .../fakeFrameGrabber/FakeFrameGrabber_params.md | 1 - 4 files changed, 2 insertions(+), 33 deletions(-) diff --git a/src/devices/fake/fakeFrameGrabber/FakeFrameGrabber.cpp b/src/devices/fake/fakeFrameGrabber/FakeFrameGrabber.cpp index 44e61d0967..a4aa8bcbc2 100644 --- a/src/devices/fake/fakeFrameGrabber/FakeFrameGrabber.cpp +++ b/src/devices/fake/fakeFrameGrabber/FakeFrameGrabber.cpp @@ -130,7 +130,6 @@ bool FakeFrameGrabber::read(yarp::os::ConnectionReader& connection) reply.addString("set_mode "); reply.addString("set_image /off"); reply.addString("available modes: ball, line, grid, size, rand, none, time"); - reply.addString("set_topIsLow on/off"); reply.addString("set_noise on/off"); reply.addString("set_snr "); reply.addString(""); @@ -163,18 +162,6 @@ bool FakeFrameGrabber::read(yarp::os::ConnectionReader& connection) } } } - else if (command.get(0).asString() == "set_topIsLow") - { - if (command.get(1).asString() == "off") { - m_topIsLow = false; - reply.addString("ack"); - } else if (command.get(1).asString() == "on") { - m_topIsLow = true; - reply.addString("ack"); - } else { - reply.addString("err"); - } - } else if (command.get(0).asString() == "set_noise") { if (command.get(1).asString() == "off") { @@ -830,8 +817,6 @@ void FakeFrameGrabber::createTestImage(yarp::sig::ImageOf& image.pixel(6, 0).g = ttxt[19] - '0'; image.pixel(6, 0).b = ttxt[20] - '0'; } - - image.setTopIsLowIndex(m_topIsLow); } diff --git a/src/devices/fake/fakeFrameGrabber/FakeFrameGrabber_ParamsParser.cpp b/src/devices/fake/fakeFrameGrabber/FakeFrameGrabber_ParamsParser.cpp index f2ee36e15d..4106930520 100644 --- a/src/devices/fake/fakeFrameGrabber/FakeFrameGrabber_ParamsParser.cpp +++ b/src/devices/fake/fakeFrameGrabber/FakeFrameGrabber_ParamsParser.cpp @@ -8,7 +8,7 @@ // This is an automatically generated file. Please do not edit it. // It will be re-generated if the cmake flag ALLOW_DEVICE_PARAM_PARSER_GERNERATION is ON. -// Generated on: Thu Mar 7 17:59:43 2024 +// Generated on: Mon Sep 16 16:44:50 2024 #include "FakeFrameGrabber_ParamsParser.h" @@ -188,20 +188,6 @@ bool FakeFrameGrabber_ParamsParser::parseParams(const yarp::os::Searchable prop_check.unput("syncro"); } - //Parser of parameter topIsLow - { - if (config.check("topIsLow")) - { - m_topIsLow = config.find("topIsLow").asBool(); - yCInfo(FakeFrameGrabberParamsCOMPONENT) << "Parameter 'topIsLow' using value:" << m_topIsLow; - } - else - { - yCInfo(FakeFrameGrabberParamsCOMPONENT) << "Parameter 'topIsLow' using DEFAULT value:" << m_topIsLow; - } - prop_check.unput("topIsLow"); - } - //Parser of parameter physFocalLength { if (config.check("physFocalLength")) diff --git a/src/devices/fake/fakeFrameGrabber/FakeFrameGrabber_ParamsParser.h b/src/devices/fake/fakeFrameGrabber/FakeFrameGrabber_ParamsParser.h index 2d48b127b7..d6c62b2aed 100644 --- a/src/devices/fake/fakeFrameGrabber/FakeFrameGrabber_ParamsParser.h +++ b/src/devices/fake/fakeFrameGrabber/FakeFrameGrabber_ParamsParser.h @@ -8,7 +8,7 @@ // This is an automatically generated file. Please do not edit it. // It will be re-generated if the cmake flag ALLOW_DEVICE_PARAM_PARSER_GERNERATION is ON. -// Generated on: Thu Mar 7 17:59:43 2024 +// Generated on: Mon Sep 16 16:44:50 2024 #ifndef FAKEFRAMEGRABBER_PARAMSPARSER_H @@ -120,7 +120,6 @@ class FakeFrameGrabber_ParamsParser : public yarp::dev::IDeviceDriverParams std::string m_fakeFrameGrabber_rpc_port = {"/fakeFrameGrabber/rpc"}; bool m_mirror = {false}; bool m_syncro = {false}; - bool m_topIsLow = {true}; double m_physFocalLength = {3.0}; double m_focalLengthX = {4.0}; double m_focalLengthY = {5.0}; diff --git a/src/devices/fake/fakeFrameGrabber/FakeFrameGrabber_params.md b/src/devices/fake/fakeFrameGrabber/FakeFrameGrabber_params.md index 6a48cb1905..50a37a916d 100644 --- a/src/devices/fake/fakeFrameGrabber/FakeFrameGrabber_params.md +++ b/src/devices/fake/fakeFrameGrabber/FakeFrameGrabber_params.md @@ -5,7 +5,6 @@ * | | fakeFrameGrabber_rpc_port | string | - | /fakeFrameGrabber/rpc | No | rpc port for the fakeFrameGrabber | | * | | mirror | bool | - | false | No | mirror height of test image | | * | | syncro | bool | - | false | No | synchronize producer and consumer, so that all images are used once and only once | | - * | | topIsLow | bool | - | true | No | explicitly set the topIsLow field in the images | | * | | physFocalLength | double | - | 3.0 | No | Physical focal length | | * | | focalLengthX | double | - | 4.0 | No | Horizontal component of the focal length | | * | | focalLengthY | double | - | 5.0 | No | Vertical component of the focal length | |