Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SASL SCRAM authentication support #742

Closed
popadi opened this issue Nov 8, 2021 · 4 comments
Closed

SASL SCRAM authentication support #742

popadi opened this issue Nov 8, 2021 · 4 comments

Comments

@popadi
Copy link

popadi commented Nov 8, 2021

I see that this issue #601 was closed without any conclusion. I see that faust-streaming/faust has SCRAM 256 and 512 as available SASL mechanisms. Any plans on having it available for robinhood/faust too?

Nothing more than adding those two extra options to the enum needs to be done, the underlying authentication libs will take care of everything. I can make a PR with the same changes myself if that's okay.

@bobh66
Copy link
Contributor

bobh66 commented Nov 8, 2021

This repo hasn't been touched in over a year, so I think it's unlikely that any changes will be merged any time soon. faust-streaming is where all new development is happening.

@popadi
Copy link
Author

popadi commented Nov 8, 2021

This repo hasn't been touched in over a year, so I think it's unlikely that any changes will be merged any time soon. faust-streaming is where all new development is happening.

So if people want to be up to date with bug fixes and features they should just switch to faust-streaming/faust? (I guess that was the main reason for the fork)

@bobh66
Copy link
Contributor

bobh66 commented Nov 8, 2021

@popadi - yes, the fork has a lot of fixes and improvements that are not in the base repo.

@popadi
Copy link
Author

popadi commented Nov 8, 2021

Thanks for the answers!

@popadi popadi closed this as completed Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants