feat(authentication): support OAuth 2.0 scopes #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robingenz
requested changes
May 8, 2022
...ingenz/capacitorjs/plugins/firebase/authentication/handlers/FacebookAuthProviderHandler.java
Outdated
Show resolved
Hide resolved
...obingenz/capacitorjs/plugins/firebase/authentication/handlers/GoogleAuthProviderHandler.java
Outdated
Show resolved
Hide resolved
...ngenz/capacitorjs/plugins/firebase/authentication/handlers/PlayGamesAuthProviderHandler.java
Outdated
Show resolved
Hide resolved
packages/authentication/ios/Plugin/Handlers/GoogleAuthProviderHandler.swift
Outdated
Show resolved
Hide resolved
|
@robingenz fixes implemented and tested, let me know if you want to see anything else. |
robingenz
requested changes
May 9, 2022
...ingenz/capacitorjs/plugins/firebase/authentication/handlers/FacebookAuthProviderHandler.java
Outdated
Show resolved
Hide resolved
...obingenz/capacitorjs/plugins/firebase/authentication/handlers/GoogleAuthProviderHandler.java
Outdated
Show resolved
Hide resolved
|
Alright, all set. I'll ping you when GoogleSignIn 6.2 comes out so we can get this merged. Thanks! |
robingenz
approved these changes
May 10, 2022
robingenz
changed the title
|
@nkalupahana Please format the files and fix the build error. |
|
@robingenz should be all good to go! |
|
@nkalupahana Great work! Thank you! |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still WIP since GoogleSignIn 6.2 still isn't out, but since it'll be out very soon and this is a somewhat substantial PR, I figured I would open it now to get an initial review.I've tested this for Google and GitHub (so should work for all OAuth) -- so I think the only one not covered by testing on my part is Facebook (all platforms) and Google Play Games (Android).Close #32
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run changeset).