From 9a4e9ff0d73a8f1de1a1eac7c6caeab190258929 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ji=C5=99=C3=AD=20Brabec?= Date: Thu, 7 Mar 2024 16:55:12 +0100 Subject: [PATCH 1/5] check-es-compat: Disallowed Eslint inline config comments to work with unminified code. --- packages/check-es-compat/bin/cli.mjs | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/check-es-compat/bin/cli.mjs b/packages/check-es-compat/bin/cli.mjs index f4c0b55..257e36a 100644 --- a/packages/check-es-compat/bin/cli.mjs +++ b/packages/check-es-compat/bin/cli.mjs @@ -22,6 +22,7 @@ async function execute(files) { // Ignore any config files useEslintrc: false, ignore: false, + allowInlineConfig: false, baseConfig: { plugins: ['ecmascript-compat'], From 2cb8ac7a997c19e33ba19259775a766d19efc259 Mon Sep 17 00:00:00 2001 From: Robat Williams Date: Thu, 7 Mar 2024 16:47:23 +0000 Subject: [PATCH 2/5] Make prettier apply to mjs file --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index e0954ca..4d18c90 100644 --- a/package.json +++ b/package.json @@ -4,7 +4,7 @@ "scripts": { "check": "npm-run-all --parallel check:*", "check:lint": "eslint --no-eslintrc --config=.eslintrc.json **/*.{js,mjs}", - "check:prettier": "prettier --check **/*.{js,json,md}", + "check:prettier": "prettier --check **/*.{js,json,md,mjs}", "ci": "npm-run-all check test", "postinstall": "lerna bootstrap", "test": "lerna run test" From c095f3165eceb827fcd8cbac359333567fd49475 Mon Sep 17 00:00:00 2001 From: Robat Williams Date: Thu, 7 Mar 2024 16:47:56 +0000 Subject: [PATCH 3/5] Fix indentation to spaces --- packages/check-es-compat/bin/cli.mjs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/check-es-compat/bin/cli.mjs b/packages/check-es-compat/bin/cli.mjs index 257e36a..a6b1bc2 100644 --- a/packages/check-es-compat/bin/cli.mjs +++ b/packages/check-es-compat/bin/cli.mjs @@ -22,7 +22,7 @@ async function execute(files) { // Ignore any config files useEslintrc: false, ignore: false, - allowInlineConfig: false, + allowInlineConfig: false, baseConfig: { plugins: ['ecmascript-compat'], From 00353321c13d3245a4d84b81bc4a824961510848 Mon Sep 17 00:00:00 2001 From: Robat Williams Date: Thu, 7 Mar 2024 16:50:15 +0000 Subject: [PATCH 4/5] Update comment --- packages/check-es-compat/bin/cli.mjs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/check-es-compat/bin/cli.mjs b/packages/check-es-compat/bin/cli.mjs index a6b1bc2..4e2f6a7 100644 --- a/packages/check-es-compat/bin/cli.mjs +++ b/packages/check-es-compat/bin/cli.mjs @@ -19,7 +19,7 @@ if (args.length === 0) { async function execute(files) { const eslint = new ESLint({ - // Ignore any config files + // Ignore any config; it's for project's own linting rather than this tool. useEslintrc: false, ignore: false, allowInlineConfig: false, From 9afb279b81cf02bcb1236c31bef98ffe96d7af84 Mon Sep 17 00:00:00 2001 From: Robat Williams Date: Thu, 7 Mar 2024 16:56:31 +0000 Subject: [PATCH 5/5] Clarify comment --- packages/check-es-compat/bin/cli.mjs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/check-es-compat/bin/cli.mjs b/packages/check-es-compat/bin/cli.mjs index 4e2f6a7..928780f 100644 --- a/packages/check-es-compat/bin/cli.mjs +++ b/packages/check-es-compat/bin/cli.mjs @@ -19,7 +19,7 @@ if (args.length === 0) { async function execute(files) { const eslint = new ESLint({ - // Ignore any config; it's for project's own linting rather than this tool. + // Ignore any config; it's for target's own linter setup rather than this tool. useEslintrc: false, ignore: false, allowInlineConfig: false,