Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[💡 FEATURE REQUEST]: Propagate arbitrary headers to the erroneous response #2006

Closed
rauanmayemir opened this issue Sep 9, 2024 · 0 comments · Fixed by roadrunner-server/grpc#136
Assignees
Labels
C-feature-request Category: feature requested, but need to be discussed
Milestone

Comments

@rauanmayemir
Copy link

Plugin

GRPC

I have an idea!

Currently, grpc plugin accepts error field as part of response headers which is a base64-encoded google.rpc.Status payload with the error code, message, details, etc.

However, it's not possible to pass server response headers (like X-Correlation-Id, X-Request-Id, etc) together with the error.

A suggestion would be to allow sending metadata headers from workers like so:

{
  "error": "base64_encoded_proto",
  "headers": {"header_key_1": "header_value_1", "header_key_2": "header_value_2"}
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature-request Category: feature requested, but need to be discussed
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants