Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐛 BUG]: redialTimeout is not respected when dynamically creating pipeline #2000

Closed
1 task done
algirdasci opened this issue Sep 5, 2024 · 3 comments · Fixed by roadrunner-server/jobs#130
Closed
1 task done
Assignees
Labels
B-bug Bug: bug, exception
Milestone

Comments

@algirdasci
Copy link

No duplicates 🥲.

  • I have searched for a similar issue in our bug tracker and didn't find any solutions.

What happened?

When dynamically creating pipeline, redialTimeout parameter is not respected and falling back to default value of 60 seeconds.

Version (rr --version)

rr version 2024.2.0 (build time: 2024-07-25T13:25:10+0000, go1.22.5), OS: linux, arch: amd64

How to reproduce the issue?

When I dynamically declare pipeline using following code:

$jobs = new Jobs(RPC::create('tcp://127.0.0.1:6001'));
$jobs->create(
    new AMQPCreateInfo(
        name: 'test',
        queue: 'test',
        redialTimeout: 10,
    )
);

The redialTimeout parameter is not respected and after losing connection to RabbitMQ server redialer exits after ~60s (see log output).

Tested same scenario when declaring queue using .rr.yaml config file - the redial_timeout parameter is respected and redialer exits after set timeout.

Relevant log output

2024-09-05T06:58:14+0000        DEBUG   amqp            exited from redialer
2024-09-05T06:58:14+0000        ERROR   amqp            amqp connection closed  {"error": "Exception (504) Reason: \"channel/connection is not open\""}
2024-09-05T06:58:14+0000        ERROR   amqp            pipeline connection was closed, redialing       {"error": "Exception (320) Reason: \"CONNECTION_FORCED - broker forced connection closure with reason 'shutdown'\"", "pipeline": "test", "driver": "amqp", "start": "2024-09-05T06:58:14+0000"}
2024-09-05T06:59:06+0000        ERROR   amqp            backoff operation failed, pipeline will be recreated    {"error": "amqp_driver_redial: dial tcp 192.168.65.254:5672: connect: connection refused"}
@rustatian
Copy link
Member

Hey @algirdasci 👋
Thank you for the report 👍. I've found where the bug is, since today is a release day, I'll fix it and release today.

@rustatian
Copy link
Member

Hey @algirdasci 👋
Release postponed a little, need to write additional tests for some plugins. ATM you may subscribe to the releases on the RR GitHub page (watch -> custom -> releases).

@algirdasci
Copy link
Author

Thanks, no problem. I'll subscribe for new release and update my instance when you'll release it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-bug Bug: bug, exception
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants