-
-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[🐛 BUG]: Delete all items from the priority queue on the pipeline destroy command #1382
Closed
8 tasks done
Labels
B-bug
Bug: bug, exception
Comments
6 tasks
rustatian
added
Y-Release blocker
Priority: Release blocker
and removed
Y-high
Priority: High
labels
Jun 12, 2023
This was referenced Jun 14, 2023
This was referenced Jun 21, 2023
The second part of this bug is to introduce an option to wait for the jobs currently being processed by a worker. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No duplicates 🥲.
What happened?
When the user calls
rpc.Destroy
for the pipeline, some jobs might already be in the priority queue. Since the priority queue is global for all pipelines, jobs from the destroyed pipeline might reach the worker. RR won't be able to ACK/NACK these JOBS, but they might sometimes break user logic inside the worker.We should delete all associated
JOBS
from the PQ and wait for themsgInFlight == 0
to be sure that there are noJOBS
inside the PQ or currently processing by the PHP worker.Version (rr --version)
<= 2.12.1
How to reproduce the issue?
sleep(1)
.rpc.Destroy
with the pipeline name simultaneously.AMQP
SQS
Beanstalk
NATS
Kafka
in-memory
boltdb
The text was updated successfully, but these errors were encountered: