Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes should have "inherit" field, not theme properties #125

Closed
mrshiposha opened this issue Apr 19, 2022 · 0 comments
Closed

Themes should have "inherit" field, not theme properties #125

mrshiposha opened this issue Apr 19, 2022 · 0 comments

Comments

@mrshiposha
Copy link
Contributor

According to the RMRK spec only a theme can inherit another theme.

But at the moment theme properties have an inherit field.

#[cfg_attr(feature = "std", derive(Eq))]
#[derive(Encode, Decode, RuntimeDebug, TypeInfo, Clone, PartialEq)]
pub struct Theme<BoundedString> {
/// Name of the theme
pub name: BoundedString,
/// Theme properties
pub properties: Vec<ThemeProperty<BoundedString>>,
}
#[cfg_attr(feature = "std", derive(Eq))]
#[derive(Encode, Decode, RuntimeDebug, TypeInfo, Clone, PartialEq)]
pub struct ThemeProperty<BoundedString> {
/// Key of the property
pub key: BoundedString,
/// Value of the property
pub value: BoundedString,
/// Inheritability
pub inherit: Option<bool>,
}

Also, I can't see where the inheritance info is stored in the Pallet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant