Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance concerns for snf.get_n_clusters() #13

Open
rmarkello opened this issue Apr 12, 2019 · 0 comments
Open

Performance concerns for snf.get_n_clusters() #13

rmarkello opened this issue Apr 12, 2019 · 0 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@rmarkello
Copy link
Owner

Currently the function calculates the graph laplacian and attempts to find the optimal number of clusters via the "eigengap" method, but:

  1. We should probably be using scipy.sparse.csgraph.laplacian() to generate the graph laplacian rather than rolling our own, and
  2. Normalizing the eigenvalues may not be the right move here; it seems like we should just be able to use the raw eigenvalue spectrum. I've experienced a few cases where the results from the function don't make sense based on the input data and I think it might be coming from this normalization procedure...

Essentially, it would be great to test the get_n_clusters() function a bit more to assess performance!
@rmarkello rmarkello added bug Something isn't working help wanted Extra attention is needed labels Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rmarkello