Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JPEG: change readme #46

Open
bluddy opened this issue Jan 27, 2021 · 3 comments
Open

JPEG: change readme #46

bluddy opened this issue Jan 27, 2021 · 3 comments

Comments

@bluddy
Copy link
Contributor

bluddy commented Jan 27, 2021

Looks like jpeg isn't supported in the code, but the readme says it is. This is very confusing to anyone looking for an image library. Am I mistaken?

@rlepigre
Copy link
Owner

Yeah, the README is not super clear, but it does say that only computing the image size is supported natively. The unix-enabled version of the library uses convert to turn JPEG images to PNG.

@bluddy
Copy link
Contributor Author

bluddy commented Jan 27, 2021

Somebody complained that it blew up for him on discord. It's possible that he tried to open a large JPEG that can't easily be converted to PNG due to lack of appropriate compression.

@cfcs
Copy link
Collaborator

cfcs commented Mar 3, 2021

@bluddy I updated the README in response to your other report (#47). Do you think that it's addressed there?

RE: conversion blowing up: It would a lot easier to track down the root cause if they would post a report here, ideally having set export OCAMLRUNPARAM=b in their shell environment first.
The imagelib pixel representation is far from ideal, with the result that we sometimes end up using a lot of memory and we take a lot of performance hits from poor cache locality because pixel data is stored in separate arrays (something that could be improved upon), but it would be nice to know if it is caused by excessive memory consumption or a bug in the code. If we can close this issue and continue that conversation in another that would be easier to manage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants