Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the Torch model factory #286

Open
mmcenta opened this issue Mar 3, 2023 · 1 comment
Open

Rework the Torch model factory #286

mmcenta opened this issue Mar 3, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request Marathon To do during Marathon

Comments

@mmcenta
Copy link
Collaborator

mmcenta commented Mar 3, 2023

Hello,

Yesterday, I noticed that the model factory functions we have for torch can have some problems when trying to use PPO with continuous actions. It should be a quick fix, but we also had these issues with creating neural networks with shared layers - so I think it might be best if we rework how these model factories work. I'll think about it and open a PR later about this, but you can let me know if there are any problems/feature requests for the model factory utils for torch.

@KohlerHECTOR KohlerHECTOR changed the title Bugs in Torch Model Factory Rework the Torch model factory Jul 13, 2023
@KohlerHECTOR
Copy link
Collaborator

This issue is related to @philippe's request to have utilities to manipulate actor, critics, and other networks. In particular to do transfer learning on DQN. So we plan to rework the model factory.
Ideas are welcome in advance of the rlberry hackathon @mmcenta @AleShi94 @omardrwch @riccardodv @brahimdriss @yann .

@KohlerHECTOR KohlerHECTOR added enhancement New feature or request Marathon To do during Marathon labels Jul 13, 2023
@AleShi94 AleShi94 self-assigned this Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Marathon To do during Marathon
Projects
None yet
Development

No branches or pull requests

3 participants