Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Praise in Python #56

Open
funtion opened this issue Feb 3, 2017 · 6 comments
Open

Praise in Python #56

funtion opened this issue Feb 3, 2017 · 6 comments

Comments

@funtion
Copy link

funtion commented Feb 3, 2017

This project is so great but I did find a Python version. So I made one and used some words in this project. I am still following the MIT licence and add the link to this project.

The Python version is at https://github.com/funtion/praise.

Hope this is OK for you. Feel free to contact me if you have any worries or comments.

Thanks

@gaborcsardi
Copy link
Collaborator

Sounds great! Maybe we should store the words in a format that can be shared between the projects? E.g. how about JSON files?

@gaborcsardi
Copy link
Collaborator

Or, even simpler, a simple list of words, one per line?

@funtion
Copy link
Author

funtion commented Feb 3, 2017

Good idea. So we don't need to maintain the list everywhere. But how can we share files in different repo?

@gaborcsardi
Copy link
Collaborator

There are some options:

  • we sync manually
  • we create one repo that has both packages
  • we use git submodules with a third repo that only has the word lists

All of these are inconvenient, in different ways....

@gaborcsardi
Copy link
Collaborator

I can we can just sync manually.

Some of use used (and will use) the praise package to teach GitHub pull requests, and then it would be confusing to have submodules, or multiple packages in a repo.

We could still convert the text files to JSON or just text, though. How about that?

@funtion
Copy link
Author

funtion commented Feb 8, 2017

Sounds good. Once you have the JSON or text file done, I can update the code. Then we sync it manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants