Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make array items take title from the parent if available #3983

Closed
1 task done
Rozamo opened this issue Nov 30, 2023 · 3 comments · Fixed by #4002
Closed
1 task done

Make array items take title from the parent if available #3983

Rozamo opened this issue Nov 30, 2023 · 3 comments · Fixed by #4002
Labels

Comments

@Rozamo
Copy link
Contributor

Rozamo commented Nov 30, 2023

Prerequisites

What theme are you using?

core

Is your feature request related to a problem? Please describe.

This is not a problem but more of an enhancement. The items in an array take the parent's property name as the title even though the parent's title has been specified. For example, this playground shows the array type property arrayProperty with the title Array Property Title and string type items. Each of its items gets the title arrayProperty-<index>.

Describe the solution you'd like

The array items should use the parent's title property to get the title if present. Therefore, for the above example, the items should have the title Array Property Title - <index>,

Describe alternatives you've considered

No response

@Rozamo Rozamo added feature Is a feature request needs triage Initial label given, to be assigned correct labels and assigned labels Nov 30, 2023
@heath-freenome
Copy link
Member

@Rozamo That is a good feature idea! Are you willing to push a PR to implement it? I believe that it could be a simple change in the ArrayField class in @rjsf/core

@heath-freenome heath-freenome added help wanted arrays core and removed needs triage Initial label given, to be assigned correct labels and assigned labels Dec 1, 2023
@Rozamo
Copy link
Contributor Author

Rozamo commented Dec 2, 2023

@heath-freenome Sure. I can take this up.

@Rozamo
Copy link
Contributor Author

Rozamo commented Dec 15, 2023

@heath-freenome Think we'd also need to make these changes to other themes as well. I have familiarity with mui but not with other themes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants