Cache reference assemblies between tests to improve performance #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmurillo
approved these changes
Jun 7, 2024
|
Nice! |
|
I also opened a PR to update the test docs to make this clearer: dotnet/roslyn-sdk#1160 |
|
This addresses part of #64. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The testing framework does a bunch of heavy lifting to resolve references for set of
ReferenceAssemblies, including potentially running the NuGet client to download packages. This class caches the ReferenceAssemblies class (which is thread-safe), so that package resolution only happens once for a given configuration.The is the same approach taken by https://github.com/dotnet/roslyn-analyzers/blob/4d5fd9da36d64d4c3370b8813122e226844fc6ed/src/Test.Utilities/AdditionalMetadataReferences.cs.
This cuts test time from ~40 seconds to ~20 seconds on my machine.