Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing R classes for imported objects #9

Open
TanguyBarthelemy opened this issue Jul 19, 2023 · 1 comment
Open

Missing R classes for imported objects #9

TanguyBarthelemy opened this issue Jul 19, 2023 · 1 comment

Comments

@TanguyBarthelemy
Copy link
Contributor

TanguyBarthelemy commented Jul 19, 2023

Comparing versions 2 and 3, the functions used to import workspaces don't create the same structure in R. In version 2, after the reading from the java object, a R object with a class is created.

It's the class "workspace" for the ws object:

https://github.com/jdemetra/rjdemetra/blob/3b8fcbdc6e8dfee840373a1911ba07da8f32963a/R/import_workspace.R#L42

It's the class "multiprocessing" for the mp object:

https://github.com/jdemetra/rjdemetra/blob/3b8fcbdc6e8dfee840373a1911ba07da8f32963a/R/import_workspace.R#L82

It's the class "sa_item" for the SaItem object:

https://github.com/jdemetra/rjdemetra/blob/3b8fcbdc6e8dfee840373a1911ba07da8f32963a/R/import_workspace.R#L88

In v3 none of this three objects gets a class at it is imported in R.

Should we add classes?

@annasmyk
Copy link
Member

yes we should for clarity and further manipulation's sake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants