Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigMatrix should support push(rows) #62

Open
MLnick opened this issue Oct 12, 2016 · 0 comments
Open

BigMatrix should support push(rows) #62

MLnick opened this issue Oct 12, 2016 · 0 comments

Comments

@MLnick
Copy link
Contributor

MLnick commented Oct 12, 2016

BigMatrix supports pulling a set of row indices, i.e. matrix.pull(rows: Array[Long]). For push, only matrix.push(rows: Array[Long], cols: Array[Int], values: Array[V]) is supported.

For common use cases of pull/push a set of rows, this effectively doubles the set of indices that must be sent (2 entries per value). Though I'm not sure if it makes that much difference on performance (it may add a bit to the comm cost of large pushes), for ease of use it would be useful to be able to push a set of rows in the same manner as pull.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants