-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notepad3 Release Candidate 4.18.507.981 is here! #480
Comments
Hello, Just quickly, I've identified two issues:
For the second issue: we had an issue on this some time ago (need to look it up, but unfortunately I'm in hurry now). I consider the template file included in the setup as "correct", while the generated .ini file is "incorrect":
I'll try to have more thorough look on this RC during the next evenings and will report further findings. |
Hello @engelhro |
Hello @engelhro,
|
Hello, @RaiKoHoff : you're right, issue #314 was about the template file, not the generation. This is really a minor thing and can be neglected I think. I just stumbled upon this when diffing my existing and the new configuration file, and accidentally created a "fresh" file from within Notepad3 which was also reviewed then. 😉 Regarding topic no. 1: no, sticky position is not activated, that was the first thing I checked. I even tried with sticky position, but even that gets ignored – each window opens with the default size and position (half width, on the right screen side)! The configuration file is also not write protected or something like that, as other options get written to it. Just the window size and position are ignored 😕 I definitively use the RC (version v4.18.507.981), but I opted for the installer version (not the portable one!). That shouldn't make a difference, but maybe this information is still of help? |
Hello @RaiKoHoff , |
@hpwamr : I will check this ... On reorganizing internal default settings:
Ed.: Current internal defaults (no .ini) are:
Ed2.: ... and current internal defaults of Section 2:
|
Personally, I like the default values of [Settings] of Notepad3.ini. |
Favorites portable and installer are different.
|
I think this is intended by @rizonesoft ? |
Thinking more about the default values, my opinion is:
should be OFF by default 🤔 - shouldn't it? |
Hm, in my opinion at least I think this is standard behavior for most, if not all, programs? So regarding expectation management for users we should not "surprise" them with a "hooray, everything is back to default" when they start Notepad3 for a 2nd time… |
@RaiKoHoff As a standard, most software saves settings by default. I think it should be on by default. But it is open for debate. |
Please test development beta "_develop_4.18.507.1023". |
One more RC issue, this time with the new "Focused View": in the search dialogue the button for "Focused View" is disabled as long as "Mark Occurrences" is not enabled (which makes sense). But after disabling "Mark Occurrences" the "Focused View" option remains enabled – which results in unexpected filtering if it gets toggled (only first line is shown in my case, independent of the actual search time). I assume these active state for these two options should be coupled? |
Hello @RaiKoHoff
I tested that version and can confirm that the two files (template provided with Notepad3 and the self-generated configuration file) are now structurally identical – except for the few expected differences for the read-only sections So this issue is already closed 👍 Thanks! |
Sorry @RaiKoHoff, I did not correctly understand how the "Sticky Windows Position" function works ! 😬 Out of the box, Notepad3 correctly holds his positions. |
Regarding the "Focused View" issues: |
Okay, I now tested version 4.18.508.1027 – the "Focused view" issue as been resolved there, and I actually like the interplay between both "Mark occurrences" settings. So this is fine now 👍 Has anyone be able to reproduce my window positioning issue (with the installer version)? It's driving me crazy, I need to return to an earlier NP3 version for daily work. That's the price one has to pay when testing beta versions or release candidates on a "production system" 😆 |
@engelhro : No, I have not been able to reproduce it, please provide your Notepad3.ini file for debugging purposes. |
Notepad3 4.18.507.981 Release Candidate, does not open hyperlink when use ctrl+ click |
@phonphen : you are right, it is broken 😞 |
Please test development beta "_develop_4.18.510.1030". |
@engelhro : please provide your Notepad3.ini to try to reproduce the initial positioning problem ... |
Okay, please find Notepad3.ini attached. I've removed all the various lexer configurations in order to provide a minified version (doesn't change the observed behavior). But the problem even exists when starting without a configuration file:
|
Very very strange, I'm not able to reproduce it ! 🤔 |
If I use windows positions which are entirely within the screen (space left, right top, down) I can not reproduce this problem. |
That's correct. Setting the window to fullscreen does not exhibit the described issue.
Done, please see issue #491. |
@engelhro & others: I think I found the problem, I had a similar behaviour. As soon as I set PosY=0, it completely ignores the window values. I'm now using PosY=6 and it works. Little suggestion: When you want to close Notepad3 with unsaved document, the save dialog is somehow out of focus. It reacts to Enter-keypress without problem (saving the document), but you don't see on which button the focus lies (no button has the "blue margin"). You have to click into the dialog first, to see it. |
@engelhro : The Notepad3.ini you provided is UTF-8 Sig. encoded. Notepad3 needs an Unicode (UTF-16 LE) encoded .ini-File , cause it is read and written using Windows API methods. Use Notepad3 to switch encoding to "Unicode" and save this file using this encoding. Maybe the problem is related to that. |
Please test development beta "_develop_4.18.512.1033". |
Ah, yeah, the old Windows approach of using UTF-16 LE to handle Unicode… I guess we'll still have to deal with that in 10 years.
Seriously? The encoding indeed might've been wrong (I have now corrected that), but of course this didn't change anything at all. All other values get written to and read from that file just fine, so only the window position and size being impacted would be a really really strange consequence. This would also not explain the problem to exist with a configuration file created by NP3 itself (with the correct encoding), or the difference between versions 3.18.311.928 and 4.18.507.981. I'll have a look at beta 4.18.512.1033 now. |
As far as I am concerned, this issue may be closed.... |
Notepad3 RC 4.18.507.981 Released. Please download it at https://rizone.tech/notepad3. Test this release thoroughly and if you created an issue, please close it. 😃
Thank you to all for your support and dedication. ❤️
The text was updated successfully, but these errors were encountered: