Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notepad3 Release Candidate 4.18.507.981 is here! #480

Closed
rizonesoft opened this issue May 7, 2018 · 33 comments
Closed

Notepad3 Release Candidate 4.18.507.981 is here! #480

rizonesoft opened this issue May 7, 2018 · 33 comments

Comments

@rizonesoft
Copy link
Owner

Notepad3 RC 4.18.507.981 Released. Please download it at https://rizone.tech/notepad3. Test this release thoroughly and if you created an issue, please close it. 😃

Thank you to all for your support and dedication. ❤️

@engelhro
Copy link

engelhro commented May 7, 2018

Hello,

Just quickly, I've identified two issues:

  1. Definitive an annoyance: the window position is not remembered and gets reset to default every time – no matter how I change it and save it to the configuration file via F7
  2. Really minor, but still an observation: the order of sections in the Notepad3.ini file is different between the default file provided with the setup (or the portable version) and the one generated by Notepad3 itself if no file is present.

For the second issue: we had an issue on this some time ago (need to look it up, but unfortunately I'm in hurry now). I consider the template file included in the setup as "correct", while the generated .ini file is "incorrect":

  • The [Window] section is written quite to the top while it actually was defined to be at the end (before the three [Recent …] sections.
  • Some sections are missing: [Settings2] (which would be okay, as these settings are to be accessed and changed only manually), but also [Toolbar Images], [Toolbar Labels] and [Suppressed Messages].
  • And finally the order of the lexer configurations is mixed up: [C/C++ Source Code] comes before [C# Source Code], [R-S-SPlus Statistics Code] before [Registry Files] and [Resource Script] instead of after them, and [Visual Basic] comes first in the [V…] sections (should appear after [VBScript] and [VHDL]).

I'll try to have more thorough look on this RC during the next evenings and will report further findings.

@hpwamr
Copy link
Collaborator

hpwamr commented May 7, 2018

Definitive an annoyance: the window position is not remembered and gets reset to default every time – no matter how I change it and save it to the configuration file via F7…

Hello @engelhro
I've tested the new RC2 portable and installer version : **Notepad3 (64-bit) RC v4.18.507.981**
I don't understand because during my tests, Notepad3 correctly remembers the size positions ! 🤔

@RaiKoHoff
Copy link
Collaborator

Hello @engelhro,
regarding your complaints:

  1. I am not able to reproduce this - maybe you have Sticky Window Position activated. In this case every new Notepad3 instance will stick to the position which has been frozen when this option was activated.

image

  1. Yes, the Notepad3 internal defaults (no Notepad3.ini file available) are slightly different to the distributed default Notepad3.ini template. So creating a new .ini from scratch (no guidance by already existing .ini) will produce the result you get.
    => Sections, which are read-only (never written by Notepad3) will not be found in a "generated from scratch" file.
    Regarding the order of written sections, I will see, what I can do for Release, the code impact should be not that big ... 😉.
    Regarding the former issue (Canonical order of sections in Notepad3.ini? #314 : "Canonical order of sections in Notepad3.ini"), the suggestion has been: to solve this by pre-ordering the initial Notepad3.ini template - not the internal generation).

@engelhro
Copy link

engelhro commented May 7, 2018

Hello,

@RaiKoHoff : you're right, issue #314 was about the template file, not the generation. This is really a minor thing and can be neglected I think. I just stumbled upon this when diffing my existing and the new configuration file, and accidentally created a "fresh" file from within Notepad3 which was also reviewed then. 😉

Regarding topic no. 1: no, sticky position is not activated, that was the first thing I checked. I even tried with sticky position, but even that gets ignored – each window opens with the default size and position (half width, on the right screen side)! The configuration file is also not write protected or something like that, as other options get written to it. Just the window size and position are ignored 😕

I definitively use the RC (version v4.18.507.981), but I opted for the installer version (not the portable one!). That shouldn't make a difference, but maybe this information is still of help?

@hpwamr
Copy link
Collaborator

hpwamr commented May 7, 2018

Regarding topic no. 1: no, sticky position is not activated, that was the first thing I checked. I even tried with sticky position, but even that gets ignored – each window opens with the default size and position (half width, on the right screen side)! The configuration file is also not write protected or something like that, as other options get written to it. Just the window size and position are ignored 😕

Hello @RaiKoHoff ,
It's seem me that bug is ? See #469 (comment) 🤔
With an installation of the box, "Sticky Windows Position" is NOT checked, BUT Notepad3 remembers its positions.
Toggling "Checked/Uncheched" is not working as expected ! 😬

@RaiKoHoff
Copy link
Collaborator

RaiKoHoff commented May 7, 2018

@hpwamr : I will check this ...

On reorganizing internal default settings:
All values from section [Settings] of the initial default template will go into the internal defaults and removed from the initial default .ini template. But shall we keep all of this values as defined? :

[Settings]
SaveSettings=1
SaveRecentFiles=1
PathNameFormat=1
;Favorites=.\Favorites\
Favorites=
TabsAsSpaces=0
TabWidth=4
MarkLongLines=1
LongLinesLimit=80
LongLineMode=1
LoadASCIIasUTF8=0
FixLineEndings=0

Ed.: Current internal defaults (no .ini) are:

[Settings] ; 0 = false, 1 = true
SaveSettings=1
SaveRecentFiles=0
PathNameFormat=0
Favorites=<win user's Favorites>
TabsAsSpaces=1
TabWidth=2
MarkLongLines=0
LongLinesLimit=72
LongLineMode=1              (edge line)
LoadASCIIasUTF8=0
FixLineEndings=1

Ed2.: ... and current internal defaults of Section 2:

[Settings2]
SingleFileInstance=0
ShellUseSystemMRU=0
WebTemplate1=           (undefined)
WebTemplate2=           (undefined)

@hpwamr
Copy link
Collaborator

hpwamr commented May 7, 2018

But shall we keep all of this values as defined? :

Personally, I like the default values of [Settings] of Notepad3.ini.
If needed to remove it from the template, I vote to keep those values internally. 👍

@hpwamr
Copy link
Collaborator

hpwamr commented May 7, 2018

Favorites portable and installer are different.

(portable)  Favorites=%USERPROFILE%\Favorites
(installer) Favorites=%APPDATA%\Rizonesoft\Notepad3\Favorites\

@RaiKoHoff
Copy link
Collaborator

I think this is intended by @rizonesoft ?

@RaiKoHoff
Copy link
Collaborator

Thinking more about the default values, my opinion is:
By default, Notepad3 should not save things automatically - only on user request, so:

SaveSettings=0
SaveRecentFiles=0

should be OFF by default 🤔 - shouldn't it?

@engelhro
Copy link

engelhro commented May 7, 2018

Hm, in my opinion at least SaveSettings should be ON by default. If I were to use Notepad3 for the first time, changed some options and then restarted later, I'd definitely assume that those settings have been saved and get reapplied.

I think this is standard behavior for most, if not all, programs? So regarding expectation management for users we should not "surprise" them with a "hooray, everything is back to default" when they start Notepad3 for a 2nd time…

@rizonesoft
Copy link
Owner Author

@RaiKoHoff As a standard, most software saves settings by default. I think it should be on by default. But it is open for debate.

@RaiKoHoff
Copy link
Collaborator

RaiKoHoff commented May 7, 2018

I wanted to suggest a SaveSettings compromise, then I found it is build in already:

  • internal default is ON, but if no .ini-File exists, "Save On Exit" is disabled, so there is no file created automatically, but when saved, it is ON by default.

Regarding startup window positioning: Out of the box (portable) installation works fine:

  • With an installation of the box, Sticky Windows Position is NOT checked, AND Notepad3 remembers its position, when closed => perfect.
  • Moving the window and activating Sticky Windows Position remembers exactly this position (freeze), regardless where I move the window then and press save settings 100x times. If I reopen it the frozen position (exactly the time the Sticky Windows Position has been activated) is restored => perfect!.

... and the `Sticky Windows Position' Info Dialog stated my description above clearly:
image

@RaiKoHoff
Copy link
Collaborator

RaiKoHoff commented May 7, 2018

Please test development beta "_develop_4.18.507.1023".
(Only changes compared to build 1022): initial distributed .ini and internal defaults creating a .ini from scratch)

@engelhro
Copy link

engelhro commented May 7, 2018

One more RC issue, this time with the new "Focused View": in the search dialogue the button for "Focused View" is disabled as long as "Mark Occurrences" is not enabled (which makes sense).

But after disabling "Mark Occurrences" the "Focused View" option remains enabled – which results in unexpected filtering if it gets toggled (only first line is shown in my case, independent of the actual search time). I assume these active state for these two options should be coupled?

@engelhro
Copy link

engelhro commented May 7, 2018

Hello @RaiKoHoff

Please test development beta "_develop_4.18.507.1023".
(Only changes compared to build 1022): initial distributed .ini and internal defaults creating a .ini from scratch)

I tested that version and can confirm that the two files (template provided with Notepad3 and the self-generated configuration file) are now structurally identical – except for the few expected differences for the read-only sections [Settings2], [Statusbar Settings], [Toolbar Images] and [Toolbar Labels] (which you explained above).

So this issue is already closed 👍 Thanks!

@hpwamr
Copy link
Collaborator

hpwamr commented May 7, 2018

Regarding startup window positioning: Out of the box (portable) installation works fine:

Sorry @RaiKoHoff, I did not correctly understand how the "Sticky Windows Position" function works ! 😬
Conclusion: "_develop_4.18.507.1023` works as expected !

Out of the box, Notepad3 correctly holds his positions.
And "Sticky Windows Position" remembers forever the position set by the user. 😉

@RaiKoHoff
Copy link
Collaborator

Regarding the "Focused View" issues:
Please test development beta "_develop_4.18.508.1024".
Keep in mind: activating check for "Mark All Occ." in find/replace dialog will disable editor's "Mark All Occ.) and reverse:
Reverse means: deactivation in find dialog reactivates editor's option and the occurrences may still stay marked, cause e.g. "selected word marking" is still active 😲

@engelhro
Copy link

engelhro commented May 8, 2018

Okay, I now tested version 4.18.508.1027 – the "Focused view" issue as been resolved there, and I actually like the interplay between both "Mark occurrences" settings. So this is fine now 👍

Has anyone be able to reproduce my window positioning issue (with the installer version)? It's driving me crazy, I need to return to an earlier NP3 version for daily work. That's the price one has to pay when testing beta versions or release candidates on a "production system" 😆

@RaiKoHoff
Copy link
Collaborator

@engelhro : No, I have not been able to reproduce it, please provide your Notepad3.ini file for debugging purposes.

@phonphen
Copy link

Notepad3 4.18.507.981 Release Candidate, does not open hyperlink when use ctrl+ click

@RaiKoHoff
Copy link
Collaborator

@phonphen : you are right, it is broken 😞

@RaiKoHoff
Copy link
Collaborator

Please test development beta "_develop_4.18.510.1030".

@RaiKoHoff
Copy link
Collaborator

@engelhro : please provide your Notepad3.ini to try to reproduce the initial positioning problem ...

@engelhro
Copy link

Okay, please find Notepad3.ini attached. I've removed all the various lexer configurations in order to provide a minified version (doesn't change the observed behavior).

Notepad3.zip

But the problem even exists when starting without a configuration file:

  • NP3 starts in the default position (half size of screen, aligned to its right).
  • Changing the window size and position and saving the configuration via F7 creates a configuration file (with the new values correctly written to it).
  • Exiting and restarting NP3 then shows the described issue: the window position is set back to default, the entries from the configuration file are simply ignored.

@hpwamr
Copy link
Collaborator

hpwamr commented May 11, 2018

Changing the window size and position and saving the configuration via F7 creates a configuration file (with the new values correctly written to it).
Exiting and restarting NP3 then shows the described issue: the window position is set back to default, the entries from the configuration file are simply ignored.

Very very strange, I'm not able to reproduce it ! 🤔
Also with your "Notepad3.ini" !! 🤔
Did you try with an other windows' user account (administrator and/or regular user) ?

@RaiKoHoff
Copy link
Collaborator

RaiKoHoff commented May 11, 2018

If I use windows positions which are entirely within the screen (space left, right top, down) I can not reproduce this problem.
But using the Windows Aero Snap feature (Win-Key + Left-Arrow, or extending the window to screen borders (snap feature) Notepad3 has definitively a problem to retrieve the correct values to remember 😲
@engelhro : Please create a separate issue for that.

@engelhro
Copy link

@RaiKoHoff:

If I use windows positions which are entirely within the screen (space left, right top, down) I can not reproduce this problem.

That's correct. Setting the window to fullscreen does not exhibit the described issue.

Please create a separate issue for that.

Done, please see issue #491.

@icstyle
Copy link

icstyle commented May 11, 2018

@engelhro & others: I think I found the problem, I had a similar behaviour. As soon as I set PosY=0, it completely ignores the window values. I'm now using PosY=6 and it works.

Little suggestion: When you want to close Notepad3 with unsaved document, the save dialog is somehow out of focus. It reacts to Enter-keypress without problem (saving the document), but you don't see on which button the focus lies (no button has the "blue margin"). You have to click into the dialog first, to see it.

@RaiKoHoff
Copy link
Collaborator

@engelhro : The Notepad3.ini you provided is UTF-8 Sig. encoded. Notepad3 needs an Unicode (UTF-16 LE) encoded .ini-File , cause it is read and written using Windows API methods. Use Notepad3 to switch encoding to "Unicode" and save this file using this encoding. Maybe the problem is related to that.

@RaiKoHoff
Copy link
Collaborator

Please test development beta "_develop_4.18.512.1033".

@engelhro
Copy link

The Notepad3.ini you provided is UTF-8 Sig. encoded. Notepad3 needs an Unicode (UTF-16 LE) encoded .ini-File , cause it is read and written using Windows API methods.

Ah, yeah, the old Windows approach of using UTF-16 LE to handle Unicode… I guess we'll still have to deal with that in 10 years.

Use Notepad3 to switch encoding to "Unicode" and save this file using this encoding. Maybe the problem is related to that.

Seriously? The encoding indeed might've been wrong (I have now corrected that), but of course this didn't change anything at all. All other values get written to and read from that file just fine, so only the window position and size being impacted would be a really really strange consequence.

This would also not explain the problem to exist with a configuration file created by NP3 itself (with the correct encoding), or the difference between versions 3.18.311.928 and 4.18.507.981.

I'll have a look at beta 4.18.512.1033 now.

@hpwamr
Copy link
Collaborator

hpwamr commented Dec 3, 2018

As far as I am concerned, this issue may be closed....

@hpwamr hpwamr closed this as completed Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants