Use more specific activationEvents

[yzhang-gh]

This extension is activated all the time. As a result, the status bar item is always visible.

I think we can use multiple activationEvents like "workspaceContains: **/*.html", "workspaceContains: _config.yml" and something else.

[ritwickdey]

First, Thanks You Very Much for the suggestion.

yep, you're right. that should not be activated if there are no HTML file in work-space. Because this is meaning less.

okay! I have changed activationEvents to "workspaceContains:**/*.html", "onLanguage:html".

[ritwickdey]

I think, we should not block activationEvents for onCommand:extension.liveServer.goOnline.

In case if anyone wants to start a server for a unknown reason......... :p .......

[yzhang-gh]

😁

[yzhang-gh]

Another small suggestion 😉.
It seems that vscode extensions are usually named in the format of vscode-lowercase-name.
Personally I think it looks better than name of mixed upper and lower case chars.

This is a picture from the vscode official iteration plan

[ritwickdey]

Sorry! I don't understand. Did you mean about the naming convention of git repo?

[yzhang-gh]

Yes, the name of git repo ...

[ritwickdey]

okay. I got that. I'll update that tonight 👍

[ritwickdey]

I updated the name. Is that okay?

[yzhang-gh]

Now it's perfect

[ritwickdey]

okay! I got another issue. workspaceContains checks also node_modules. Can I exclude it?

[yzhang-gh]

😮

It supports glob patterns. You can try !node_modules/**/*.

If it doesn't work, maybe we should open a vscode issue. (And this is the original PR)

[ritwickdey]

workspaceContains:**/*.html", "workspaceContains:!node_modules/**/*,

even if I write this, extension will be activated because of the first line.

[yzhang-gh]

I would suggest that we should stop using **/*.html, it's too general. And that means we require there is at least a HTML file in the root folder.

We can add more patterns for common web project structure later

[ritwickdey]

but if we don't use **/*.html , then it will show every time.

[yzhang-gh]

I guess that's because you still have !node_modules/**/* 😳

I mean

"activationEvents": [
    "workspaceContains:*.html",
    "onLanguage:html",
    "onCommand:extension.liveServer.goOnline",
    "onCommand:extension.liveServer.goOffline"
]

[ritwickdey]

"workspaceContains:*.html", => that will not work for sub folders.

Anyway, I am able to restrict that by code. :)

[yzhang-gh]

👌