Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figured bass collison (Figures displaying at incorrect timestamp) #2533

Closed
vivianteresa opened this issue Dec 7, 2021 · 2 comments
Closed
Labels

Comments

@vivianteresa
Copy link

vivianteresa commented Dec 7, 2021

Problem description:

I am having trouble with displaying some of the figured bass figures in my score - in one measure there is one set of figures underneath beat 1, and another underneath beat 3; but when I display the file in the Verovio MEI viewer, the figures for beat 3 appear under beat 1 (that is, the two figures collide). This is happening even though the timestamps in the MEI code seem to be correct (an image of the code and score in the Verovio Editor is below).

To Reproduce

  1. I converted a Sibelius file to MEI using the latest version of the SibMEI converter. The MEI file is available on my GitHub repository. The raw version is here: https://raw.githubusercontent.com/vivianteresa/harmonia-sacra-mei/master/TheBlessedVirgin'sExpostulationMEI.mei
  2. I then uploaded that file to the Verovio Editor.
  3. A screenshot of what the Editor displays, with the colliding figures, is below. The set of figures that should be underneath beat 3 is appearing underneath beat 1. This problem also occurs when I upload the MEI file to the Verovio MEI viewer.

Expected behavior
In Sibelius the figures (b6/5 and b6/4) are assigned to beats 1 and 3, respectively. I am not sure why the second set of figures (b6/4) is appearing under beat 1.

Input data

> 			<staff xml:id="m-119" n="2">
>                         <layer xml:id="m-120" n="1">
>                            <note xml:id="m-121" dur.ppq="1024" dur="1" pnum="48" oct="3" pname="c" vel="0" stem.dir="up" tstamp.real="00:00:04.8" />
>                         </layer>
>                      </staff>
>                      <harm xml:id="m-122" staff="2" startid="#m-121" tstamp="1.000000" ho="2.1328mm" layer="1">
>                         <fb xml:id="m-123">
>                            <f xml:id="m-124" n="1">♭6</f>
>                            <f xml:id="m-125" n="2">5</f>
>                         </fb>
>                      </harm>
>                      <harm xml:id="m-126" staff="2" startid="#m-121" tstamp="2.000000" ho="1.1328mm" layer="1">
>                         <fb xml:id="m-127" />
>                      </harm>
>                      <harm xml:id="m-128" staff="2" startid="#m-121" tstamp="2.000000" ho="2.1328mm" layer="1">
>                         <fb xml:id="m-129" />
>                      </harm>
>                      <harm xml:id="m-130" staff="2" startid="#m-121" tstamp="2.000000" ho="2.1328mm" layer="1">
>                         <fb xml:id="m-131" />
>                      </harm>
>                      <harm xml:id="m-132" staff="2" startid="#m-121" tstamp="3.000000" ho="2.1328mm" layer="1">
>                         <fb xml:id="m-133">
>                            <f xml:id="m-134" n="1">♭6</f>
>                            <f xml:id="m-135" n="2">4</f>
>                         </fb>
>                      </harm>

Verovio information

  • The latest/current version of the Verovio Editor at https://editor.verovio.org/ (I am unsure of the exact version number but will add it to this issue if I find it)
    -Verovio MEI Viewer version 3.8.0-dev-c1c8189
  • I am unfamiliar with "binding" and am not sure what kind is used - but will add this information to the issue if/when I find it

Environment information (as appropriate)

  • MacOS BigSur
  • Firefox 94.0.2

Screenshots
The figured bass as it appears in Sibelius:

Screen Shot 2021-12-07 at 6 02 35 AM

The figured bass as it appears in the Verovio Editor and in the Verovio MEI viewer:

Screen Shot 2021-12-07 at 6 03 11 AM

@lpugin
Copy link
Contributor

lpugin commented Dec 7, 2021

@vivianteresa for next time, your snippet should be a complete MEI file and look like this:

<?xml version="1.0" encoding="UTF-8"?>
<?xml-model href="https://music-encoding.org/schema/4.0.1/mei-all.rng" type="application/xml" schematypens="http://relaxng.org/ns/structure/1.0"?>
<?xml-model href="https://music-encoding.org/schema/4.0.1/mei-all.rng" type="application/xml" schematypens="http://purl.oclc.org/dsdl/schematron"?>
<mei xmlns="http://www.music-encoding.org/ns/mei" meiversion="4.0.1">
   <meiHead>
      <fileDesc>
         <titleStmt>
            <title>Figure bass placement</title>
         </titleStmt>
         <pubStmt>
            <date isodate="2021-12-07">2021-12-07</date>
         </pubStmt>
         <seriesStmt>
            <title>Verovio test suite</title>
         </seriesStmt>
         <notesStmt>
            <annot>
               <p></p>
            </annot>
         </notesStmt>
      </fileDesc>
      <encodingDesc>
         <appInfo>
            <application version="unknown">
               <name>Verovio</name>
            </application>
         </appInfo>
      </encodingDesc>
   </meiHead>
   <music>
      <body>
         <mdiv>
            <score>
               <scoreDef>
                  <staffGrp>
                     <staffDef n="2" lines="5" clef.shape="F" clef.line="4" key.sig="1f" meter.count="3" meter.unit="4"/>
                  </staffGrp>
               </scoreDef>
               <section>
                  <measure n="1">
                     <staff xml:id="m-119" n="2">
                        <layer xml:id="m-120" n="1">
                           <note xml:id="m-121" dur.ppq="1024" dur="1" pnum="48" oct="3" pname="c" vel="0" stem.dir="up" tstamp.real="00:00:04.8"/>
                        </layer>
                     </staff>
                     <harm xml:id="m-122" staff="2" startid="#m-121" tstamp="1.000000" ho="2.1328mm" layer="1">
                        <fb xml:id="m-123">
                           <f xml:id="m-124" n="1">♭6</f>
                           <f xml:id="m-125" n="2">5</f>
                        </fb>
                     </harm>
                     <harm xml:id="m-126" staff="2" startid="#m-121" tstamp="2.000000" ho="1.1328mm" layer="1">
                        <fb xml:id="m-127"/>
                     </harm>
                     <harm xml:id="m-128" staff="2" startid="#m-121" tstamp="2.000000" ho="2.1328mm" layer="1">
                        <fb xml:id="m-129"/>
                     </harm>
                     <harm xml:id="m-130" staff="2" startid="#m-121" tstamp="2.000000" ho="2.1328mm" layer="1">
                        <fb xml:id="m-131"/>
                     </harm>
                     <harm xml:id="m-132" staff="2" startid="#m-121" tstamp="3.000000" ho="2.1328mm" layer="1">
                        <fb xml:id="m-133">
                           <f xml:id="m-134" n="1">♭6</f>
                           <f xml:id="m-135" n="2">4</f>
                        </fb>
                     </harm>
                  </measure>
               </section>
            </score>
         </mdiv>
      </body>
   </music>
</mei>

@lpugin
Copy link
Contributor

lpugin commented Dec 7, 2021

The problem seems to come from the fact that all harm/fb are having a @startid="#m-121", which means they are all positioned under the same note. Also, there are some empty fb, which do not make sense. Removing them and using only tstamp without @startid fixes the issue

<?xml version="1.0" encoding="UTF-8"?>
<?xml-model href="https://music-encoding.org/schema/4.0.1/mei-all.rng" type="application/xml" schematypens="http://relaxng.org/ns/structure/1.0"?>
<?xml-model href="https://music-encoding.org/schema/4.0.1/mei-all.rng" type="application/xml" schematypens="http://purl.oclc.org/dsdl/schematron"?>
<mei xmlns="http://www.music-encoding.org/ns/mei" meiversion="4.0.1">
   <meiHead>
      <fileDesc>
         <titleStmt>
            <title>Figure bass placement</title>
         </titleStmt>
         <pubStmt>
            <date isodate="2021-12-07">2021-12-07</date>
         </pubStmt>
         <seriesStmt>
            <title>Verovio test suite</title>
         </seriesStmt>
         <notesStmt>
            <annot>
               <p></p>
            </annot>
         </notesStmt>
      </fileDesc>
      <encodingDesc>
         <appInfo>
            <application version="unknown">
               <name>Verovio</name>
            </application>
         </appInfo>
      </encodingDesc>
   </meiHead>
   <music>
      <body>
         <mdiv>
            <score>
               <scoreDef>
                  <staffGrp>
                     <staffDef n="2" lines="5" clef.shape="F" clef.line="4" key.sig="1f" meter.count="3" meter.unit="4"/>
                  </staffGrp>
               </scoreDef>
               <section>
                  <measure n="1">
                     <staff xml:id="m-119" n="2">
                        <layer xml:id="m-120" n="1">
                           <note xml:id="m-121" dur.ppq="1024" dur="1" pnum="48" oct="3" pname="c" vel="0" stem.dir="up" tstamp.real="00:00:04.8"/>
                        </layer>
                     </staff>
                     <harm xml:id="m-122" staff="2" tstamp="1.000000" ho="2.1328mm" layer="1">
                        <fb xml:id="m-123">
                           <f xml:id="m-124" n="1">♭6</f>
                           <f xml:id="m-125" n="2">5</f>
                        </fb>
                     </harm>
                     <harm xml:id="m-132" staff="2" tstamp="3.000000" ho="2.1328mm" layer="1">
                        <fb xml:id="m-133">
                           <f xml:id="m-134" n="1">♭6</f>
                           <f xml:id="m-135" n="2">4</f>
                        </fb>
                     </harm>
                  </measure>
               </section>
            </score>
         </mdiv>
      </body>
   </music>
</mei>

image

It looks more like a SibMEI export problem. I would recommend to open an issue there. For now I am closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants