Replies: 13 comments
-
Hi, |
Beta Was this translation helpful? Give feedback.
-
Yes, @Docudoctor, your observation is specially interesting when addressing how those fields would be indexed, and so, it is clear that $a and $b (if available) should be indexed as a unit (single field). However, according to https://www.loc.gov/marc/authority/ad110.html this $c refers to Location of meeting, and both examples in that page are, effectively, places where conference meetings were held, not the place (city) of an institution, like the typical RISM usage. |
Beta Was this translation helpful? Give feedback.
-
I would prefer not to rename fields if possible, because this comes with a quantity of subtle breakage that is quite difficult debug. If it is about the naming, we can create an alias in the model. For example, why do you want to rename address to name? |
Beta Was this translation helpful? Give feedback.
-
If renaming fields causes problems, I didn't know, thanks for letting me know. I'll remake the proposal removing and adding fields (attributes). My proposal to rename address to name_d (not name) was to avoid a delete a field to add another one, but I see that it a bad solution. Regarding the _d fields, if Solr takes care of the needed functionality (including sorting, #978), I'll remove them as well. I haven't tested 8.x release yet. Finally, there is the issue of indexing $a and $b (and maybe $c, but this would be a cataloguing discussion) together in Solr. Do you have another case in Muscat where more than one Marc subfield is indexed as a single Solr field? |
Beta Was this translation helpful? Give feedback.
-
I have no additions from the Series C project side, but I will admit that 110 $c can be seen as a RISM local practice. As an aside, we (the Series C group) have noticed the Institutions are particularly well-stocked with fields for locations: 043 (Country code), the 371 (with country and cities), and 551 (Places), this 110$c, and 368, and 370. I note that LC uses 370 for what—I think—@fjorba would expect RISM's 110$c info to be? This is LC's authority record for itself: https://lccn.loc.gov/n78089035 |
Beta Was this translation helpful? Give feedback.
-
Taking into account that renaming columns is problematic and that the _d fields are no longer needed, my second proposal is:
Adapt marc_institution.rb methods accordingly. This subordinate_unit should optionally be shown in the institution list, maybe as a parameter, replacing one of the current columns. I'm not proposing anything regarding the Solr indexing issue here, as I don't have a clear idea about how to implement it. However, if this reorganisations is accepted, I can work on it in order to address the #1196 issue. Is this ok now? |
Beta Was this translation helpful? Give feedback.
-
Dear Ferran, |
Beta Was this translation helpful? Give feedback.
-
Yes, I was talking about institutions, certainly. I don't know if it should be different in your case but, of course, you know it better. Thanks. |
Beta Was this translation helpful? Give feedback.
-
Maybe a lighter alternative to the display issue could be that the attribute name has both $a and $b (if available), because it would imply less modifications. That would be more acceptable? I'd like to know which path should I follow that would be accepted and merged upstream. Which alternative would you prefer, @xhero? |
Beta Was this translation helpful? Give feedback.
-
After testing several configurations, my current proposal is:
Those diff --git a/config/marc/tag_config_source.yml b/config/marc/tag_config_source.yml
index 4d878918..7f6469ec 100644
--- a/config/marc/tag_config_source.yml
+++ b/config/marc/tag_config_source.yml
@@ -657,9 +657,11 @@
- - a
- :occurrences: "?"
:foreign_class: ^0
- :foreign_field: name
+ :foreign_field: corporate_name
- - b
- - :occurrences: "*"
+ - :occurrences: "?"
+ :foreign_class: ^0
+ :foreign_field: subordinate_unit
- - c
- :occurrences: "*"
- - g Autocomplete works well because it searches the And the names in the instutions list also appear in full (as they keep the old Comments? I'll create my PR with the implementation of this proposal. |
Beta Was this translation helpful? Give feedback.
-
Done in #1287 |
Beta Was this translation helpful? Give feedback.
-
I'd like to add that my patch works not only for interactive cataloging but also with marc import ( |
Beta Was this translation helpful? Give feedback.
-
Closed by #1335 |
Beta Was this translation helpful? Give feedback.
-
In the 7.x branch of Muscat, there are several Institution attributes (Rails attributes or db columns) that seem unused, and some of them could find a better usage. The current schema is:
muscat/db/schema.rb
Line 149 in 951dd12
The following table tries to match them with the Marc21 standard and the current Muscat usage.
https://www.loc.gov/marc/authority/ad110.html
So, at this moment, the attributes (columns) not filled in are:
Those filled in but apparently unused are:
At the same time, I miss:
So, my proposal is, following the order of the columns definition:
I'm unsure if implementing a repetable $b as attribute is worthwhile, as there are alternatives, as joining them with a dot (instead of: $a Institution. $b Subordinate. $b Minor use: $a Institution. $b Subordinate. Minor)
In RISM database, there are only a few subordinate units:
However, in any university, for example, there are hundreds, and if they are not show in the institution list, it is impossible to know which to select, for example:
On the other hand, from my external point of view, I'd say that the Place maybe should be taken from 371 $b instead of 110 $c; however that is a minor point that should be addressed somewhere else.
@xhero, Do you think this is reasonable? Would you accept some PR to implement this?
Thanks
Beta Was this translation helpful? Give feedback.
All reactions