fix: cannot update cluster since clustername is not set #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isingwavecloud into mike/fix-clustername-compatibility
wjf3121
reviewed
Sep 9, 2024
| fmt.Sprintf("Cluster name cannot be changed, previous: %s, updated: %s", *previous.ClusterName, *updated.ClusterName), | ||
| ) | ||
|
|
||
| // only check clusterName for BYOC |
There was a problem hiding this comment.
Why do we only check BYOC clusters? Hosted clusters cannot change their names either IIRC.
There was a problem hiding this comment.
There is no clusterName field exposed in the tf plugin data model. So the clusterName is not set in the updated object, which is transformed from the data model object submitted by tf plan. The previous object is created from the GET tenants API data directly. So clusterName is set in previous object.
In short, clusterName is not exposed to the tf plugin, the value is not set so we need to ignore it, and users cannot change it via tf plugin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The update method will throw the error: "Cluster name cannot be changed, previous is default-control-plane, now is not set".