Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: How should FE display the execution error? #4811

Closed
BowenXiao1999 opened this issue Aug 23, 2022 · 5 comments
Closed

Discussion: How should FE display the execution error? #4811

BowenXiao1999 opened this issue Aug 23, 2022 · 5 comments
Assignees

Comments

@BowenXiao1999
Copy link
Contributor

BowenXiao1999 commented Aug 23, 2022

Now FE scheduler do not correctly display the execution error, see

https://github.com/singularity-data/risingwave/blob/a50393a30b7830d392b0092af460871c8e9cede1/src/frontend/src/scheduler/distributed/stage.rs#L393

Should frontend aware of the detail reason like (ExprError, Divde by Zero error etc)? If yes, maybe we should consider how to encode this into proto.

cc @liurenjie1024. May relates to #3908

@liurenjie1024
Copy link
Contributor

Currently we don't do fault tolerant of query execution, so I think frontend doesn't need to know the exact error kind, and just the error message.

@fuyufjh
Copy link
Member

fuyufjh commented Aug 23, 2022

+1 for error message only, because it seems difficult to define all kinds of errors.

@fuyufjh fuyufjh added this to the release-0.1.13 milestone Aug 31, 2022
@fuyufjh fuyufjh removed this from the release-0.1.13 milestone Sep 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2022

This issue has been open for 60 days with no activity. Could you please update the status? Feel free to continue discussion or close as not planned.

@fuyufjh
Copy link
Member

fuyufjh commented Nov 5, 2022

cc. @TennyZhuang

@BowenXiao1999
Copy link
Contributor Author

Now the solution is we wrap the execution err msg in string into a Err struct returned by streaming GRPC API. So when there is an execution failure in CN tasks, FE scheduler will imediately know and return Err.

let status = stauts_res_inner.map_err(SchedulerError::from)?;

rpc CreateTask(CreateTaskRequest) returns (stream TaskInfoResponse);

Now FE should be able to get the execution failure so I think we can close this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants