-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discussion: How should FE display the execution error? #4811
Comments
Currently we don't do fault tolerant of query execution, so I think frontend doesn't need to know the exact error kind, and just the error message. |
+1 for error message only, because it seems difficult to define all kinds of errors. |
This issue has been open for 60 days with no activity. Could you please update the status? Feel free to continue discussion or close as not planned. |
cc. @TennyZhuang |
Now the solution is we wrap the execution err msg in string into a Err struct returned by streaming GRPC API. So when there is an execution failure in CN tasks, FE scheduler will imediately know and return Err.
risingwave/proto/task_service.proto Line 75 in 6f1764f
Now FE should be able to get the execution failure so I think we can close this issue now. |
Now FE scheduler do not correctly display the execution error, see
https://github.com/singularity-data/risingwave/blob/a50393a30b7830d392b0092af460871c8e9cede1/src/frontend/src/scheduler/distributed/stage.rs#L393
Should frontend aware of the detail reason like (ExprError, Divde by Zero error etc)? If yes, maybe we should consider how to encode this into proto.
cc @liurenjie1024. May relates to #3908
The text was updated successfully, but these errors were encountered: