feat: support checking error message for statement & bump to 0.8.0 #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xxchan <xxchan22f@gmail.com>
Signed-off-by: xxchan <xxchan22f@gmail.com>
Signed-off-by: xxchan <xxchan22f@gmail.com>
xxchan
commented
Nov 22, 2022
| match res { | ||
| ["ok"] => {} | ||
| ["error", err_str @ ..] => { | ||
| let err_str = err_str.join(" "); |
There was a problem hiding this comment.
I guess this won't always work, since we do line.split_whitespace(). 😅 But I don't bother fixing it now.
Signed-off-by: xxchan <xxchan22f@gmail.com>
skyzh
approved these changes
Nov 23, 2022
| sql: String, | ||
| err: Arc<dyn std::error::Error + Send + Sync>, | ||
| kind: RecordKind, | ||
| }, | ||
| #[error("{kind} is expected to fail with error:\n\t\x1b[91m{expected_err}\x1b[0m\nbut got error:\n\t\x1b[91m{err}\x1b[0m\n[SQL] {sql}")] |
There was a problem hiding this comment.
would be better if this can be controlled by flags, otherwise will mess up people who pipe the output to a file.
There was a problem hiding this comment.
Indeed. A similar problem: #104
3 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #30