Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Result an associated type for DB #16

Closed
Xuanwo opened this issue Jan 20, 2022 · 1 comment
Closed

Make Result an associated type for DB #16

Xuanwo opened this issue Jan 20, 2022 · 1 comment

Comments

@Xuanwo
Copy link
Contributor

Xuanwo commented Jan 20, 2022

By the way, can we go a step further? e.g., add a Result associated type for DB, so that we can pass any type apart from String as query result. (Not needed in this PR)

Also, I would recommend adding an example for validator in examples folder.

Originally posted by @skyzh in #15 (review)
@Xuanwo Xuanwo mentioned this issue Jan 20, 2022
Merged
@xxchan xxchan mentioned this issue Aug 15, 2022
Closed
@xxchan
Copy link
Member

xxchan commented Dec 8, 2022

We are using Vec<Vec<String>> now. There seem to be no need to use an associated type.

@xxchan xxchan closed this as not planned Won't fix, can't repro, duplicate, stale Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Xuanwo @xxchan