Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differnce in time domain EIS and PybaMM EIS #24

Closed
Akila1993 opened this issue Nov 20, 2023 · 1 comment
Closed

Differnce in time domain EIS and PybaMM EIS #24

Akila1993 opened this issue Nov 20, 2023 · 1 comment

Comments

@Akila1993
Copy link

I am writing to you regarding the discussion I have opened here regarding the difference between time domain and frequency domain EIS profiles.

According to the suggestion by Dr. Ferran when we reduce the amplitude of input current the difference between two profiles is reducing. According to Ferran it is because pybamm-eis uses a linearised version of the model so it is only an approximation.

Could you please elaborate this behaviour further like how (what equations) it is linearised or if we could use the nonlinear model / or linear model to match the Okane 2022 parameter set and the model. Or please provide any reference for pybamm-eis.

Thank you.

@rtimms
Copy link
Collaborator

rtimms commented Jun 5, 2024

Fixed by pybamm-team/PyBaMM#4139 and #26

@rtimms rtimms closed this as completed Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants