Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enum is defined check and fallback values #491

Merged
merged 1 commit into from
Jun 12, 2023
Merged

enum is defined check and fallback values #491

merged 1 commit into from
Jun 12, 2023

Conversation

latonz
Copy link
Contributor

@latonz latonz commented Jun 9, 2023

enum is defined check and fallback values

Fixes #488

Checklist

  • The existing code style is followed
  • The commit message follows our guidelines
  • Performed a self-review of my code
  • Hard-to-understand areas of my code are commented
  • The documentation is updated (as applicable)
  • Unit tests are added/updated
  • Integration tests are added/updated (as applicable, especially if feature/bug depends on roslyn or framework version in use)

@latonz latonz self-assigned this Jun 9, 2023
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #491 (1dfc785) into main (b17f666) will decrease coverage by 0.14%.
The diff coverage is 91.93%.

@@            Coverage Diff             @@
##             main     #491      +/-   ##
==========================================
- Coverage   92.08%   91.95%   -0.14%     
==========================================
  Files         135      147      +12     
  Lines        4282     4647     +365     
  Branches      591      586       -5     
==========================================
+ Hits         3943     4273     +330     
- Misses        225      254      +29     
- Partials      114      120       +6     
Impacted Files Coverage Δ
src/Riok.Mapperly.Abstractions/MapEnumAttribute.cs 0.00% <0.00%> (-100.00%) ⬇️
...iok.Mapperly.Abstractions/MapEnumValueAttribute.cs 0.00% <0.00%> (ø)
...scriptors/InlineExpressionMappingBuilderContext.cs 95.12% <ø> (ø)
...appingBodyBuilders/UserMethodMappingBodyBuilder.cs 90.47% <ø> (ø)
...tors/MappingBuilders/EnumToStringMappingBuilder.cs 100.00% <ø> (ø)
...erly/Descriptors/MappingBuilders/MappingBuilder.cs 100.00% <ø> (ø)
src/Riok.Mapperly/Descriptors/MappingCollection.cs 100.00% <ø> (ø)
...ptors/Mappings/Enums/EnumFromStringParseMapping.cs 65.21% <ø> (ø)
.../Descriptors/Mappings/Enums/EnumToStringMapping.cs 100.00% <ø> (ø)
...iok.Mapperly/Descriptors/Mappings/MethodMapping.cs 95.00% <ø> (ø)
... and 53 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@latonz latonz marked this pull request as ready for review June 12, 2023 09:40
@latonz latonz enabled auto-merge (squash) June 12, 2023 09:40
@latonz latonz requested a review from ni507 June 12, 2023 09:59
@latonz latonz requested a review from ni507 June 12, 2023 13:08
@latonz latonz merged commit f0065c8 into riok:main Jun 12, 2023
@latonz latonz deleted the 488-enum-fallback-value branch June 12, 2023 13:18
@github-actions
Copy link

🎉 This PR is included in version 2.9.0-next.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@latonz latonz added this to the v2.9.0 milestone Jun 14, 2023
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enum mapping fallback value
2 participants