fix: enable static user methods for instance mappers #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #364 +/- ##
==========================================
- Coverage 91.71% 91.65% -0.06%
==========================================
Files 109 126 +17
Lines 3379 3907 +528
Branches 438 543 +105
==========================================
+ Hits 3099 3581 +482
- Misses 189 215 +26
- Partials 91 111 +20
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
latonz
requested changes
Apr 20, 2023
TimothyMakkison
force-pushed
the
add_static_instance
branch
from
983df9d to
655e93f
Compare
|
Ok, I've deleted the |
latonz
approved these changes
Apr 20, 2023
TimothyMakkison
force-pushed
the
add_static_instance
branch
from
655e93f to
78adfff
Compare
latonz
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #200
BuildUserImplementedMappingto allow static instance members.UserMethodTestand renamed some other tests, deleting the unused snapshotsIs it possible to get the diagnostic
PartialInstanceMethodInStaticMapper? It looks like line 83 should be impossible to hit in normal C# code because you can't have an instance method in a static class.